* RFA: Fix make check-g++ abort if libstdc++-v3 is not built
@ 2002-12-18 7:16 Nick Clifton
2002-12-18 7:46 ` Jason Merrill
0 siblings, 1 reply; 2+ messages in thread
From: Nick Clifton @ 2002-12-18 7:16 UTC (permalink / raw)
To: gcc-patches
Hi Guys,
May I please have permission to apply the following patch ?
It fixes a problem I encountered when I attempted to run "make
check-g++" without having built the libstdc++-v3 library. The test
harness respects the global variable HAVE_LIBSTDCXX_V3 defined by
the Makefile in the gcc build directory and attemps to run the
'testsuite_flags' script that should be in the libstdc++-v3
directory. But since the library has not been built, the
script is not present and the test harness aborts with an expect
error message.
After applying the patch, the make check-g++ reports lots of errors,
because of the missing library, but it does not abort.
Cheers
Nick
2002-12-18 Nick Clifton <nickc@redhat.com>
* lib/g++.exp (g++_include_flags): Only invoke testsuite_flags if
the libstdc++-v3 directory has been found.
Index: gcc/testsuite/lib/g++.exp
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/lib/g++.exp,v
retrieving revision 1.27
diff -c -3 -p -w -r1.27 g++.exp
*** gcc/testsuite/lib/g++.exp 26 Sep 2002 09:51:44 -0000 1.27
--- gcc/testsuite/lib/g++.exp 18 Dec 2002 15:05:17 -0000
*************** proc g++_include_flags { paths } {
*** 90,96 ****
--- 90,98 ----
if { ${HAVE_LIBSTDCXX_V3} } {
set odir_v3 [lookfor_file ${gccpath} libstdc++-v3]
+ if { ${odir_v3} != "" } {
append flags [exec sh ${odir_v3}/testsuite_flags --build-includes]
+ }
} else {
set odir_v2 [lookfor_file ${gccpath} libstdc++]
set sdir_v2 [lookfor_file ${srcdir} libstdc++]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: RFA: Fix make check-g++ abort if libstdc++-v3 is not built
2002-12-18 7:16 RFA: Fix make check-g++ abort if libstdc++-v3 is not built Nick Clifton
@ 2002-12-18 7:46 ` Jason Merrill
0 siblings, 0 replies; 2+ messages in thread
From: Jason Merrill @ 2002-12-18 7:46 UTC (permalink / raw)
To: Nick Clifton; +Cc: gcc-patches
OK.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-12-18 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-12-18 7:16 RFA: Fix make check-g++ abort if libstdc++-v3 is not built Nick Clifton
2002-12-18 7:46 ` Jason Merrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).