* [PATCH] Obvious fix of -feliminate-dwarf2-dups
@ 2003-03-06 10:23 Zdenek Dvorak
2003-03-06 13:18 ` Zdenek Dvorak
0 siblings, 1 reply; 6+ messages in thread
From: Zdenek Dvorak @ 2003-03-06 10:23 UTC (permalink / raw)
To: gcc-patches
Hello,
the size of die is computed incorrectly if there are references to
other CU's; I am commiting the attached patch as obvious.
Zdenek
Changelog:
* dwarf2out.c (size_of_die): Compute size of external reference
to die correctly.
Index: dwarf2out.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/dwarf2out.c,v
retrieving revision 1.405
diff -c -3 -p -r1.405 dwarf2out.c
*** dwarf2out.c 5 Mar 2003 22:37:52 -0000 1.405
--- dwarf2out.c 6 Mar 2003 00:39:58 -0000
*************** size_of_die (die)
*** 6349,6355 ****
size += 1;
break;
case dw_val_class_die_ref:
! size += DWARF_OFFSET_SIZE;
break;
case dw_val_class_fde_ref:
size += DWARF_OFFSET_SIZE;
--- 6349,6358 ----
size += 1;
break;
case dw_val_class_die_ref:
! if (AT_ref_external (a))
! size += DWARF2_ADDR_SIZE;
! else
! size += DWARF_OFFSET_SIZE;
break;
case dw_val_class_fde_ref:
size += DWARF_OFFSET_SIZE;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Obvious fix of -feliminate-dwarf2-dups
2003-03-06 10:23 [PATCH] Obvious fix of -feliminate-dwarf2-dups Zdenek Dvorak
@ 2003-03-06 13:18 ` Zdenek Dvorak
2003-03-06 17:33 ` Jason Merrill
0 siblings, 1 reply; 6+ messages in thread
From: Zdenek Dvorak @ 2003-03-06 13:18 UTC (permalink / raw)
To: gcc-patches
Hello,
OK for 3.3 branch?
Zdenek
> the size of die is computed incorrectly if there are references to
> other CU's; I am commiting the attached patch as obvious.
>
> Zdenek
>
> Changelog:
> * dwarf2out.c (size_of_die): Compute size of external reference
> to die correctly.
>
> Index: dwarf2out.c
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/dwarf2out.c,v
> retrieving revision 1.405
> diff -c -3 -p -r1.405 dwarf2out.c
> *** dwarf2out.c 5 Mar 2003 22:37:52 -0000 1.405
> --- dwarf2out.c 6 Mar 2003 00:39:58 -0000
> *************** size_of_die (die)
> *** 6349,6355 ****
> size += 1;
> break;
> case dw_val_class_die_ref:
> ! size += DWARF_OFFSET_SIZE;
> break;
> case dw_val_class_fde_ref:
> size += DWARF_OFFSET_SIZE;
> --- 6349,6358 ----
> size += 1;
> break;
> case dw_val_class_die_ref:
> ! if (AT_ref_external (a))
> ! size += DWARF2_ADDR_SIZE;
> ! else
> ! size += DWARF_OFFSET_SIZE;
> break;
> case dw_val_class_fde_ref:
> size += DWARF_OFFSET_SIZE;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Obvious fix of -feliminate-dwarf2-dups
2003-03-06 13:18 ` Zdenek Dvorak
@ 2003-03-06 17:33 ` Jason Merrill
0 siblings, 0 replies; 6+ messages in thread
From: Jason Merrill @ 2003-03-06 17:33 UTC (permalink / raw)
To: Zdenek Dvorak; +Cc: gcc-patches
On Thu, 6 Mar 2003 14:18:13 +0100, Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz> wrote:
> OK for 3.3 branch?
-feliminate-dwarf2-dups isn't supported in 3.3, so I don't think this patch
is needed.
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Obvious fix of -feliminate-dwarf2-dups
2003-03-07 15:17 ` Jason Merrill
@ 2003-03-07 15:23 ` Zdenek Dvorak
0 siblings, 0 replies; 6+ messages in thread
From: Zdenek Dvorak @ 2003-03-07 15:23 UTC (permalink / raw)
To: Jason Merrill; +Cc: gcc-patches
Hello,
> >> -feliminate-dwarf2-dups isn't supported in 3.3, so I don't think this
> >> patch is needed.
> >
> > huh? The option is there; what is the sense of leaving this feature
> > buggy?
>
> Do you think that this patch fixes the only bug in that feature?
Probably no.
> I'm sure there are more, since it's never really gotten a workout.
I know of some people using it (admitedly, I am not so sure they really
do after finding such fundamental bug).
Zdenek
> I suppose applying this to 3.3 wouldn't hurt, though.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Obvious fix of -feliminate-dwarf2-dups
2003-03-07 1:28 Zdenek Dvorak
@ 2003-03-07 15:17 ` Jason Merrill
2003-03-07 15:23 ` Zdenek Dvorak
0 siblings, 1 reply; 6+ messages in thread
From: Jason Merrill @ 2003-03-07 15:17 UTC (permalink / raw)
To: Zdenek Dvorak; +Cc: gcc-patches
On Fri, 7 Mar 2003 02:28:05 +0100, Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz> wrote:
>> -feliminate-dwarf2-dups isn't supported in 3.3, so I don't think this
>> patch is needed.
>
> huh? The option is there; what is the sense of leaving this feature
> buggy?
Do you think that this patch fixes the only bug in that feature? I'm sure
there are more, since it's never really gotten a workout. I suppose
applying this to 3.3 wouldn't hurt, though.
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Obvious fix of -feliminate-dwarf2-dups
@ 2003-03-07 1:28 Zdenek Dvorak
2003-03-07 15:17 ` Jason Merrill
0 siblings, 1 reply; 6+ messages in thread
From: Zdenek Dvorak @ 2003-03-07 1:28 UTC (permalink / raw)
To: jason, gcc-patches
Hello,
> > OK for 3.3 branch?
>
> -feliminate-dwarf2-dups isn't supported in 3.3, so I don't think this
> patch is needed.
>
> Jason
huh? The option is there; what is the sense of leaving this feature
buggy?
Zdenek
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-03-07 15:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-06 10:23 [PATCH] Obvious fix of -feliminate-dwarf2-dups Zdenek Dvorak
2003-03-06 13:18 ` Zdenek Dvorak
2003-03-06 17:33 ` Jason Merrill
2003-03-07 1:28 Zdenek Dvorak
2003-03-07 15:17 ` Jason Merrill
2003-03-07 15:23 ` Zdenek Dvorak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).