From: Thomas Rodgers <trodgers@redhat.com>
To: libstdc++@gcc.gnu.org
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Include netinet/in.h in include/experimental/internet
Date: Mon, 30 Sep 2019 23:25:00 -0000 [thread overview]
Message-ID: <xkqek19pxt75.fsf@redhat.com> (raw)
In-Reply-To: <a83e28f3-3b68-d16a-e39b-7465efa2055f@fgznet.ch>
Looks good to me.
Andreas Tobler writes:
> Hi all,
>
> I'm going to commit the attached patch to trunk.
> It is preapproved by Jonathan. (via #irc)
>
> On FreeBSD the netinet/in.h header is not included by arpa/inet.h, so do the
> include if we have the _GLIBCXX_HAVE_NETINET_IN_H defined.
>
> This makes all the experimental/net/internet test cases pass here.
>
> Any comments?
>
> TIA,
> Andreas
>
> Commit one-liner:
>
> Include netinet/in.h in include/experimental/internet
>
> 2019-09-30 Andreas Tobler <andreast@gcc.gnu.org>
>
> * include/experimental/internet: Include netinet/in.h if we have
> _GLIBCXX_HAVE_NETINET_IN_H defined.
>
> Index: include/experimental/internet
> ===================================================================
> --- include/experimental/internet (revision 276342)
> +++ include/experimental/internet (working copy)
> @@ -51,6 +51,9 @@
> #ifdef _GLIBCXX_HAVE_ARPA_INET_H
> # include <arpa/inet.h> // inet_ntop
> #endif
> +#ifdef _GLIBCXX_HAVE_NETINET_IN_H
> +# include <netinet/in.h> // IPPROTO_IP
> +#endif
> #ifdef _GLIBCXX_HAVE_NETINET_TCP_H
> # include <netinet/tcp.h> // TCP_NODELAY
> #endif
prev parent reply other threads:[~2019-09-30 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 16:59 Andreas Tobler
2019-09-30 23:25 ` Thomas Rodgers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xkqek19pxt75.fsf@redhat.com \
--to=trodgers@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).