From: DJ Delorie <dj@redhat.com>
To: "Sebastian Perta" <sebastian.perta@renesas.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] RL78 one_cmplhi2 improvement
Date: Tue, 27 Feb 2018 15:52:00 -0000 [thread overview]
Message-ID: <xnbmgatoph.fsf@greed.delorie.com> (raw)
In-Reply-To: <000101d3afe0$523338a0$f699a9e0$@renesas.com> (sebastian.perta@renesas.com)
"Sebastian Perta" <sebastian.perta@renesas.com> writes:
> Is this similar to what you had in mind?
Yes. Did it affect code size in any of the larger tests? I was hoping
that it wouldn't force too much into 8-bit registers and cause more
moves to be needed elsewhere.
(and even if it didn't, I think this one feels "more correct" than the
other, as it retains more of the "I'm 16 bits"-ness of the operand)
>> If it doesn't work out, consider this patch approved, though.
> Can I checkin now?
Yes. Thanks!
Make sure the indentation is correct, of course. It wasn't in the
email, and that confused me at first.
prev parent reply other threads:[~2018-02-27 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 12:15 Sebastian Perta
2018-02-20 19:44 ` DJ Delorie
2018-02-27 15:33 ` Sebastian Perta
2018-02-27 15:52 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnbmgatoph.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sebastian.perta@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).