public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: "REIX\, Tony" <tony.reix@atos.net>
Cc: dje.gcc@gmail.com, iant@golang.org,
	matthieu.sarter.external@atos.net,
	       gcc-patches@gcc.gnu.org
Subject: Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF
Date: Wed, 07 Jun 2017 15:37:00 -0000	[thread overview]
Message-ID: <xnink73j2l.fsf@greed.delorie.com> (raw)
In-Reply-To: <B37989F2852398498001550C29155BE5CF0C0C@FRCRPVV9EX4MSX.ww931.my-it-solutions.net> (tony.reix@atos.net)


"REIX, Tony" <tony.reix@atos.net> writes:
> It appears that XNEWVEC() calls xmalloc which prints a message and
> calls xexit if malloc fails.

Objection removed then ;-)

> So, yes, we check if (strtab == NULL) though there is no way that
> XDELETEVEC(NULL) breaks something.  However, it is a classic
> programming style.

Yup, I noted that.  Just mentioning the inconsistency.

  reply	other threads:[~2017-06-07 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 23:25 David Edelsohn
2017-06-06 23:52 ` DJ Delorie
2017-06-07 13:16   ` REIX, Tony
2017-06-07 15:37     ` DJ Delorie [this message]
2017-06-07 14:23 ` REIX, Tony
2017-06-07 14:43   ` [PATCH,AIX] " David Edelsohn
     [not found] <B37989F2852398498001550C29155BE5CD3512@FRCRPVV9EX3MSX.ww931.my-it-solutions.net>
2017-05-15 14:12 ` REIX, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xnink73j2l.fsf@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iant@golang.org \
    --cc=matthieu.sarter.external@atos.net \
    --cc=tony.reix@atos.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).