From: DJ Delorie <dj@redhat.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: tony.reix@atos.net, iant@golang.org,
matthieu.sarter.external@atos.net,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF
Date: Tue, 06 Jun 2017 23:52:00 -0000 [thread overview]
Message-ID: <xno9u03c95.fsf@greed.delorie.com> (raw)
In-Reply-To: <CAGWvnykVCf_hKP5Qo7jCXXR=FxzNCGOGcSqoYqmGz++80Fa_tw@mail.gmail.com> (message from David Edelsohn on Tue, 6 Jun 2017 19:25:09 -0400)
David Edelsohn <dje.gcc@gmail.com> writes:
> This patch generally looks good to me -- it clearly is an incremental
> improvement. One of the libiberty maintainers, such as Ian, needs to
> approve the patch.
As AIX maintainer, I think you have the authority to approve patches
like this, which only affect your OS. I see no reason to reject the
patch myself, other than:
+ symtab = XNEWVEC (struct external_syment, ocr->nsyms * SYMESZ);
+ if (!simple_object_internal_read (sobj->descriptor,
There's no check to see if XNEWVEC succeeded.
Also, the use of XDELETEVEC is inconsistently protected with a "if (foo
!= NULL)" throughout, but passing NULL to XDELETEVEC (essentially,
free()) is allowed anyway, so this is only a stylistic issue, which I'm
not particularly worried about.
next prev parent reply other threads:[~2017-06-06 23:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 23:25 David Edelsohn
2017-06-06 23:52 ` DJ Delorie [this message]
2017-06-07 13:16 ` REIX, Tony
2017-06-07 15:37 ` [PATCH,AIX] " DJ Delorie
2017-06-07 14:23 ` REIX, Tony
2017-06-07 14:43 ` [PATCH,AIX] " David Edelsohn
[not found] <B37989F2852398498001550C29155BE5CD3512@FRCRPVV9EX3MSX.ww931.my-it-solutions.net>
2017-05-15 14:12 ` REIX, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xno9u03c95.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@golang.org \
--cc=matthieu.sarter.external@atos.net \
--cc=tony.reix@atos.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).