From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 9B3FB3854805 for ; Tue, 15 Dec 2020 22:58:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9B3FB3854805 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 51B673137; Tue, 15 Dec 2020 23:58:42 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IzIU65NMOUtv; Tue, 15 Dec 2020 23:58:42 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddb2f4.dip0.t-ipconnect.de [79.221.178.244]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id D21D93136; Tue, 15 Dec 2020 23:58:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1608073122; bh=brgMAsdEYDBDJijt9D9UQ97idlntEKaZobe8fTb//Vw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FruzpGvIO3cnd/BmqZ1VIQNnJDuHSsr7sLOmYY5v9qHeF89H/Skg8GJpwBYIb4Tqd qETXrTWTwCfmWjAvoMoyzlGofqP+aokCrG2Ia1T9hprUeLD2qzOt/h1A9/TPpjHip9 XktdyjHQ+REztzyr+aLzm6Da/4mz0n8oOZYtraS7vSzDYhxbpZ2XA8CXXT9juxxbIc ALGSwdSTEk1jMsHtiQcx5epHs3DoArVW3QphgOEcRSc04G/GRv9jxTfo9sAmCyyd+2 VndLa3zPVjhbM8oE/6h70/tFxYbJW3M5jv6r9QLtbMdyyX0HzKAlChHzl29BGXZqWv NuEhcJH6Z642Q== From: Rainer Orth To: Pierre-Marie de Rodat Cc: gcc-patches@gcc.gnu.org, Pascal Obry Subject: Re: [Ada] Fix serial port baud rate setting on GNU/Linux References: <20201215114241.GA35315@adacore.com> Date: Tue, 15 Dec 2020 23:58:40 +0100 In-Reply-To: <20201215114241.GA35315@adacore.com> (Pierre-Marie de Rodat's message of "Tue, 15 Dec 2020 06:42:41 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3790.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 22:58:44 -0000 Hi Pierre-Marie, > This fixes an issue when setting the baud rate. The baud rate is set > using the cfsetospeed and cfsetispeed system calls. The code is using > speed_t for clarity. The non-blocking status is only reset when Block is > True. And serial blocking mode is now properly set according to termios > manual. > > Add documentation about a way to debug and test a serial port on > GNU/Linux without the need for a physical serial port. > > Tested on x86_64-pc-linux-gnu, committed on trunk this patch broke Linux/x86_64 bootstrap (Fedora 29): g-sercom.adb:307:53: "ICANON" is undefined make[7]: *** [../gcc-interface/Makefile:299: g-sercom.o] Error 1 I suspect s-oscons-tmplt.c needs a change to define ICANON. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University