From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Ian Lance Taylor <iant@golang.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, gofrontend-dev@googlegroups.com
Subject: Re: libgo patch committed: Update to 1.11 release
Date: Fri, 28 Sep 2018 14:28:00 -0000 [thread overview]
Message-ID: <ydd1s9dvh0e.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <CAOyqgcUgXMYAkVQco8dcmEChazODizFkZwUiH01jPEpnWNvS3w@mail.gmail.com> (Ian Lance Taylor's message of "Mon, 24 Sep 2018 14:46:34 -0700")
Hi Ian,
> I've committed a patch to update libgo to the 1.11 release. As usual
> for these updates, the patch is too large to attach to this e-mail
> message. I've attached some of the more relevant directories. This
> update required some minor patches to the gotools directory and the Go
> testsuite, also included here. Bootstrapped and ran Go testsuite on
> x86_64-pc-linux-gnu. Committed to mainline.
I just found another issue: unlike Solaris 11, Solaris 10 lacks memmem,
breaking the build:
/vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c: In function 'Index':
/vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c:96:6: error: implicit declaration of function 'memmem'; did you mean 'memset'? [-Werror=implicit-function-declaration]
96 | p = memmem(a.__values, a.__count, b.__values, b.__count);
| ^~~~~~
| memset
/vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c:96:4: error: assignment to 'const byte *' {aka 'const unsigned char *'} from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
96 | p = memmem(a.__values, a.__count, b.__values, b.__count);
| ^
/vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c: In function 'IndexString':
/vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c:111:4: error: assignment to 'const byte *' {aka 'const unsigned char *'} from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
111 | p = memmem(a.str, a.len, b.str, b.len);
| ^
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2018-09-28 14:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 21:49 Ian Lance Taylor
2018-09-25 7:06 ` Andreas Schwab
2018-09-25 7:57 ` Andreas Schwab
2018-09-25 9:05 ` Andreas Schwab
2018-09-25 14:39 ` Ian Lance Taylor
2018-09-25 13:10 ` Rainer Orth
2018-09-25 13:34 ` Rainer Orth
2018-09-26 5:04 ` Ian Lance Taylor
2018-09-26 8:55 ` Rainer Orth
2018-09-26 7:57 ` Andreas Schwab
2018-09-26 8:59 ` Rainer Orth
2018-09-26 12:54 ` Ian Lance Taylor
2018-09-26 11:12 ` Andreas Schwab
2018-09-26 12:49 ` Ian Lance Taylor
2018-10-01 20:18 ` Ian Lance Taylor
2018-09-26 14:52 ` H.J. Lu
2018-09-26 15:16 ` H.J. Lu
2018-10-01 20:28 ` Ian Lance Taylor
2018-10-01 20:59 ` H.J. Lu
2018-10-02 0:06 ` H.J. Lu
2018-10-02 0:59 ` Ian Lance Taylor
2018-10-02 2:37 ` H.J. Lu
2018-10-02 4:09 ` Ian Lance Taylor
2018-10-03 14:09 ` H.J. Lu
2018-10-03 22:04 ` Ian Lance Taylor
2018-09-28 14:28 ` Rainer Orth [this message]
2018-10-02 17:13 ` Ian Lance Taylor
2018-10-04 12:05 ` Rainer Orth
2018-09-26 7:58 Uros Bizjak
2018-09-26 15:22 ` Ian Lance Taylor
2018-09-27 20:26 ` Uros Bizjak
2018-09-28 7:13 ` Uros Bizjak
2018-10-02 15:13 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd1s9dvh0e.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=iant@golang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).