From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11913 invoked by alias); 20 Jan 2011 17:19:21 -0000 Received: (qmail 11898 invoked by uid 22791); 20 Jan 2011 17:19:20 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Jan 2011 17:19:15 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 3AEFA947; Thu, 20 Jan 2011 18:19:13 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OUuqV7JHY2yY; Thu, 20 Jan 2011 18:19:11 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 83673946; Thu, 20 Jan 2011 18:19:11 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p0KHJArE006177; Thu, 20 Jan 2011 18:19:10 +0100 (MET) From: Rainer Orth To: Ralf Wildenhues Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org, Hans Boehm , Paolo Bonzini , Janis Johnson , Ben Elliston Subject: Re: [testsuite, build] Convert boehm-gc testsuite to DejaGnu (PR boehm-gc/11412) References: <20110106211734.GG17791@gmx.de> <20110118202141.GG28213@gmx.de> Date: Thu, 20 Jan 2011 18:03:00 -0000 In-Reply-To: <20110118202141.GG28213@gmx.de> (Ralf Wildenhues's message of "Tue, 18 Jan 2011 21:21:41 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-01/txt/msg01399.txt.bz2 Ralf Wildenhues writes: >> Ok for mainline (either now, or, more likely, after 4.6 branches? > > I'm not the right person to decide this; the build system specific > parts look ok to me. In site.exp, you set srcdir to $(srcdir) and not Fine, thanks. > an absolute value; there's an Automake bug open about this issue > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7833 pending feedback from > http://thread.gmane.org/gmane.comp.sysutils.dejagnu.bugs/345 > and since there is precedent also for using $(srcdir) (in v3 and > libjava), I guess that is ok too. That's where I copied that snippet from :-) I've just filed an Automake RFE to allow adding to the automatically generated site.exp. Once that gets implemented, those contortions can go away and everything will be consistent. Given the lack of further comments/approval, I'll probably ping this patch (and the gnat.dg cleanup) early next week, seeking a global reviewer for comments. By that time, I'll have something in place to prune the ranlib warnings Iain reported. I doubt doing so in libtool with --silent would be appropriate. It's a pity we have to live without a testsuite maintainer for so long. Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University