From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Nikhil Benesch <nikhil.benesch@gmail.com>
Cc: Ian Lance Taylor <iant@golang.org>,
gcc-patches <gcc-patches@gnu.org>,
gofrontend-dev <gofrontend-dev@googlegroups.com>
Subject: Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types
Date: Wed, 16 Dec 2020 20:20:13 +0100 [thread overview]
Message-ID: <ydd3605zhg2.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <da43feb7-116e-e1a7-dd45-efe2a63aa55a@gmail.com> (Nikhil Benesch's message of "Wed, 16 Dec 2020 09:00:50 -0500")
Hi Nikhil,
> On 12/15/20 3:00 AM, Nikhil Benesch wrote:
>> If this patch looks good, I'll submit it upstream tomorrow.
>
> Assuming no news is good news, I sent
> https://go-review.googlesource.com/c/gofrontend/+/278672.
sorry for the delay, but unfortunately news is not so good: I get
runtime_sysinfo.go:315:18: error: use of undefined type '_ucontext'
315 | type _ucontext_t _ucontext
| ^
runtime_sysinfo.go:963:22: error: use of undefined type '_nv_alloc_ops'
963 | type _nv_alloc_ops_t _nv_alloc_ops
| ^
runtime_sysinfo.go:945:267: error: use of undefined type '_ns_postinit_s'
945 | type _netstack struct { netstack_u struct { nu_modules [21+1]*byte; }; netstack_m_state [21+1]uint32; netstack_lock _kmutex_t; netstack_next *_netstack; netstack_stackid int32; netstack_numzones int32; netstack_refcnt int32; netstack_flags int32; netstack_postinit *_ns_postinit_s; }
| ^
on both sparc and x86.
gen-sysinfo.go has
type _ucontext_t _ucontext
// type _ucontext struct { uc_flags uint32; uc_link *_ucontext_t; uc_sigmask _sigset_t; uc_stack _stack_t; uc_mcontext _mcontext_t; uc_xrs _xrs_t; uc_filler [2+1]int32; }
type _nv_alloc_ops_t _nv_alloc_ops
// type _nv_alloc_ops struct { nv_ao_init func(*_nv_alloc_t, ___va_list) int32; nv_ao_fini func(*_nv_alloc_t); nv_ao_alloc func(*_nv_alloc_t, uint32) *byte; nv_ao_free func(*_nv_alloc_t, *byte, uint32); nv_ao_reset func(*_nv_alloc_t); }
type _netstack struct { netstack_u struct { nu_modules [21+1]*byte; }; netstack_m_state [21+1]uint32; netstack_lock _kmutex_t; netstack_next *_netstack; netstack_stackid int32; netstack_numzones int32; netstack_refcnt int32; netstack_flags int32; netstack_postinit *_ns_postinit_s; }
// type _ns_postinit_s struct { ns_pi_fn func_ns_applyfn_t; ns_pi_arg uint32; ns_pi_next *_ns_postinit_s; }
// type _ns_postinit_t _ns_postinit_s
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2020-12-16 19:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 22:57 Nikhil Benesch
2020-12-10 2:48 ` Ian Lance Taylor
2020-12-10 19:18 ` Rainer Orth
2020-12-10 19:31 ` Nikhil Benesch
2020-12-10 19:34 ` Rainer Orth
2020-12-10 19:49 ` Nikhil Benesch
2020-12-10 21:44 ` Rainer Orth
2020-12-13 21:55 ` Nikhil Benesch
2020-12-13 23:30 ` Nikhil Benesch
2020-12-14 7:39 ` Ian Lance Taylor
2020-12-14 8:22 ` Nikhil Benesch
2020-12-14 10:30 ` Rainer Orth
2020-12-15 3:14 ` Nikhil Benesch
2020-12-15 3:34 ` Ian Lance Taylor
2020-12-15 3:48 ` Nikhil Benesch
2020-12-15 8:00 ` Nikhil Benesch
2020-12-16 14:00 ` Nikhil Benesch
2020-12-16 19:20 ` Rainer Orth [this message]
2020-12-16 20:13 ` Nikhil Benesch
2020-12-17 4:59 ` Nikhil Benesch
2020-12-17 12:28 ` Rainer Orth
2020-12-17 16:31 ` Nikhil Benesch
2020-12-17 18:05 ` Ian Lance Taylor
2020-12-17 18:21 ` Nikhil Benesch
2020-12-21 4:16 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd3605zhg2.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=iant@golang.org \
--cc=nikhil.benesch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).