public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Solaris] Fix profiling
Date: Tue, 24 May 2011 15:54:00 -0000	[thread overview]
Message-ID: <ydd39k4tal8.fsf@manam.CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <201105222222.28396.ebotcazou@adacore.com> (Eric Botcazou's	message of "Sun, 22 May 2011 22:22:28 +0200")

Hi Eric,

> after http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02139.html profiling uses 
> TLS support where available.  This breaks on SPARC/Solaris 8 and 9 (at least) 
> because the associated libraries aren't linked in.

this is PR gcov-profile/48845.

> Tested on SPARC/Solaris 8 and SPARC64/Solaris 9 (the Solaris 10 machine isn't 
> in very good shape right now), OK for the mainline?
>
>
> 2011-05-22  Eric Botcazou  <ebotcazou@adacore.com>
>
> 	* config/sol2.h (LIB_SPEC): Link TLS support for profiling.

While I've got a testsuite patch to fix this (which also fixes/cleanes
up a couple of other issues in that area), I agree that this should work
out of the box and without the user having to know about such an
implementation detail.

On the other hand, the patch is only necessary for tree profiling,
i.e. with -fprofile-generate, so I'm checking in the following.

Bootstrapped without regressions on i386-pc-solaris2.{[89], 1[01]},
installed on mainline.

Thanks for the patch.

	Rainer


2011-05-22  Eric Botcazou  <ebotcazou@adacore.com>
	    Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR gcov-profile/48845
	* config/sol2.h (LIB_SPEC): Link TLS support for tree profiling.

diff --git a/gcc/config/sol2.h b/gcc/config/sol2.h
--- a/gcc/config/sol2.h
+++ b/gcc/config/sol2.h
@@ -136,6 +136,8 @@ along with GCC; see the file COPYING3.  
    %{!symbolic:\
      %{pthreads|pthread:" \
         LIB_THREAD_LDFLAGS_SPEC " -lpthread " LIB_TLS_SPEC "} \
+     %{fprofile-generate*:" \
+        LIB_THREAD_LDFLAGS_SPEC " " LIB_TLS_SPEC "} \
      %{p|pg:-ldl} -lc}"
 
 #undef  ENDFILE_SPEC

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

  parent reply	other threads:[~2011-05-24 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22 22:25 Eric Botcazou
2011-05-24 14:52 ` Eric Botcazou
2011-05-24 15:54 ` Rainer Orth [this message]
2011-05-24 22:29   ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ydd39k4tal8.fsf@manam.CeBiTec.Uni-Bielefeld.DE \
    --to=ro@cebitec.uni-bielefeld.de \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).