From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Sandra Loosemore <sandra@codesourcery.com>,
Richard Biener <rguenther@suse.de>,
Thomas Schwinge <thomas@codesourcery.com>
Subject: Re: [Patch] Add 'default' to -foffload=; document that flag [PR67300]
Date: Tue, 29 Jun 2021 22:47:56 +0200 [thread overview]
Message-ID: <ydd4kdg4cub.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <f19b48c5-0701-9ca0-5697-04788573e58e@codesourcery.com> (Tobias Burnus's message of "Tue, 29 Jun 2021 15:47:03 +0200")
Hi Tobias,
> On 29.06.21 13:58, Jakub Jelinek wrote:
>
>> Also, wonder if we shouldn't print the list of configured targets in that
>> case, see candidates_list_and_hint functions and its callers.
>> And it is unclear why we use fatal_error, can't unknown offload target names
>> be simply ignored after emitting error?
>
> Done so – as the changes now became a bit larger, I have attached the
> new version of the patch – despite the LGTM.
this patch broke Solaris bootstrap (both 32 and 64-bit sparc and x86):
/vol/gcc/src/hg/master/local/gcc/gcc.c: In function 'bool check_offload_target_name(const char*, ptrdiff_t)':
/vol/gcc/src/hg/master/local/gcc/gcc.c:4010:23: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
4010 | cand[n - c] = '\0';
| ~~~~~~~~~~~~^~~~~~
In file included from /vol/gcc/src/hg/master/local/gcc/system.h:706,
from /vol/gcc/src/hg/master/local/gcc/gcc.c:31:
/vol/gcc/src/hg/master/local/gcc/../include/libiberty.h:733:36: note: at offset 1 into destination object of size 1 allocated by '__builtin_alloca'
733 | # define alloca(x) __builtin_alloca(x)
| ~~~~~~~~~~~~~~~~^~~
/vol/gcc/src/hg/master/local/gcc/gcc.c:4000:29: note: in expansion of macro 'alloca'
4000 | char *cand = (char *) alloca (strlen (OFFLOAD_TARGETS) + 1);
| ^~~~~~
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2021-06-29 20:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 12:08 Tobias Burnus
2021-06-17 12:27 ` Jakub Jelinek
2021-06-17 16:03 ` Tobias Burnus
2021-06-17 17:41 ` Sandra Loosemore
2021-06-17 17:50 ` Jakub Jelinek
2021-06-17 19:28 ` Tobias Burnus
2021-06-17 19:40 ` Jakub Jelinek
2021-06-17 21:57 ` Sandra Loosemore
2021-06-17 23:05 ` Tobias Burnus
2021-06-18 22:47 ` Sandra Loosemore
2021-06-28 11:28 ` Tobias Burnus
2021-06-28 15:51 ` Tobias Burnus
2021-06-28 22:34 ` Sandra Loosemore
2021-06-29 11:58 ` Jakub Jelinek
2021-06-29 13:47 ` Tobias Burnus
2021-06-29 13:51 ` Jakub Jelinek
2021-06-29 20:47 ` Rainer Orth [this message]
2021-06-29 21:02 ` Christophe Lyon
2021-06-30 20:12 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd4kdg4cub.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
--cc=sandra@codesourcery.com \
--cc=thomas@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).