From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 31E38385700A for ; Tue, 29 Jun 2021 20:48:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31E38385700A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 74CC2B4C05; Tue, 29 Jun 2021 22:47:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2GRl3ftp7G-n; Tue, 29 Jun 2021 22:47:57 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50854661.dip0.t-ipconnect.de [80.133.70.97]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id E1B9AB46DD; Tue, 29 Jun 2021 22:47:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1624999677; bh=/LHGtb3UqeaeDlmjegHhHhaoYd2yNX9fkCPtGIJcGC0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ECzJ165V8lfJr8gqjU5OGffdyyFOpAUUKSrJh1LimNm3vpM+SZ/e0ILLQGara7rBa 76BtytLFy9hzzeEn1WGtnLmZOVqKuT+aiA47jYrfsOFFe1ihapchuAVsf8BpBL5307 JCCr/c6rHAVdhdvTI7+hJD/IFFW/HsaGjXxdwT2eaRTQTAmFQamfmaCERDhns3AtU+ 5Vii3QUZNTKTPyh1LCaYFKw0sklepZxyEqCWq+XSDwrmdDho6NzSUlCXeql3BlgAmq BqXhc8E9m16d1cadp/F8qQ8K6O9mL6sAVocBgeR6JpX3JUr0NM6kxg00g1GpQVjTXS lCsoo+Ddwcp+g== From: Rainer Orth To: Tobias Burnus Cc: Jakub Jelinek , gcc-patches , Sandra Loosemore , Richard Biener , Thomas Schwinge Subject: Re: [Patch] Add 'default' to -foffload=; document that flag [PR67300] References: <20210617175054.GI7746@tucnak> <07d9e298-55d0-0e80-84f5-5d5d75c9e341@codesourcery.com> <20210617194010.GJ7746@tucnak> <7e4ad7a0-e601-b97f-9caa-9f10befbe84e@codesourcery.com> <81177be7-97bd-5c1e-2649-5ebe8eeb47b4@mentor.com> <89a1a17b-2e2d-238e-856c-b38c9aacc7ef@codesourcery.com> <4af01e92-c1e7-8cfc-d635-45aba3a48232@codesourcery.com> <20210629115856.GR7746@tucnak> Date: Tue, 29 Jun 2021 22:47:56 +0200 In-Reply-To: (Tobias Burnus's message of "Tue, 29 Jun 2021 15:47:03 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3787.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2021 20:48:02 -0000 Hi Tobias, > On 29.06.21 13:58, Jakub Jelinek wrote: > >> Also, wonder if we shouldn't print the list of configured targets in that >> case, see candidates_list_and_hint functions and its callers. >> And it is unclear why we use fatal_error, can't unknown offload target n= ames >> be simply ignored after emitting error? > > Done so =E2=80=93 as the changes now became a bit larger, I have attached= the > new version of the patch =E2=80=93 despite the LGTM. this patch broke Solaris bootstrap (both 32 and 64-bit sparc and x86): /vol/gcc/src/hg/master/local/gcc/gcc.c: In function 'bool check_offload_tar= get_name(const char*, ptrdiff_t)': /vol/gcc/src/hg/master/local/gcc/gcc.c:4010:23: error: writing 1 byte into = a region of size 0 [-Werror=3Dstringop-overflow=3D] 4010 | cand[n - c] =3D '\0'; | ~~~~~~~~~~~~^~~~~~ In file included from /vol/gcc/src/hg/master/local/gcc/system.h:706, from /vol/gcc/src/hg/master/local/gcc/gcc.c:31: /vol/gcc/src/hg/master/local/gcc/../include/libiberty.h:733:36: note: at of= fset 1 into destination object of size 1 allocated by '__builtin_alloca' 733 | # define alloca(x) __builtin_alloca(x) | ~~~~~~~~~~~~~~~~^~~ /vol/gcc/src/hg/master/local/gcc/gcc.c:4000:29: note: in expansion of macro= 'alloca' 4000 | char *cand =3D (char *) alloca (strlen (OFFLOAD_TARGETS) + 1); | ^~~~~~ Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University