public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: GCC Patches <GCC-patches@gcc.gnu.org>,
	David Edelsohn <dje.gcc@gmail.com>,
	Andrew Stubbs <ams@codesourcery.com>
Subject: Re: [PATCH] configury : Fix LEB128 support for non-GNU assemblers.
Date: Wed, 25 Nov 2020 11:37:33 +0100	[thread overview]
Message-ID: <ydd4kldafiq.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <0099CE62-D849-40BA-BCBD-1AD3882AA9AD@sandoe.co.uk> (Iain Sandoe's message of "Wed, 25 Nov 2020 09:49:58 +0000")

Hi Iain,

> I’ve had this patch in my Darwin trees for (literally) years, it is
> relevant to
> the GCC ports that use a non-binutils assembler.
>
> At present, even if such an assembler supports LEB128,  the GCC config
> is setting HAVE_LEB128 = 0.
>
> The ports I know of that can benefit from a change here are:
[...]
> Solaris (bootstrapped and tests running on GCC211, but maybe Rainer would
>             want wider checks).

I've just manually tried the augmented test on Solaris 10-11.4, SPARC
and x86.  While the Solaris/SPARC assembler handles it just fine, the
x86 one chokes in a known way:

Assembler: 
	"/homes/ro/leb128.s", line 2 : Syntax error
	Near line: "	.uleb128 L2 - L1"

> I guess we could exclude specific ports that don’t want to use leb128 with
> a target elif in the configuration.

I'll include the patch in tonight's Solaris bootstraps for good measure,
but it seems fine to me as is.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

  reply	other threads:[~2020-11-25 10:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  9:49 Iain Sandoe
2020-11-25 10:37 ` Rainer Orth [this message]
2020-11-26 13:08   ` Rainer Orth
2020-11-26 13:17     ` Iain Sandoe
2020-11-26 13:26       ` Rainer Orth
2020-11-26 13:30         ` Jakub Jelinek
2020-11-26 15:07           ` Rainer Orth
2020-11-26 20:28             ` Iain Sandoe
2020-11-26 21:39               ` Rainer Orth
2020-11-26 21:43                 ` Iain Sandoe
2020-11-27 10:29                   ` [PATCH v2] " Iain Sandoe
2020-11-27 10:37                     ` Jakub Jelinek
2020-11-26 14:48         ` [PATCH] " Iain Sandoe
2020-11-26 14:52           ` Andrew Stubbs
2020-11-25 17:49 ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ydd4kldafiq.fsf@CeBiTec.Uni-Bielefeld.DE \
    --to=ro@cebitec.uni-bielefeld.de \
    --cc=GCC-patches@gcc.gnu.org \
    --cc=ams@codesourcery.com \
    --cc=dje.gcc@gmail.com \
    --cc=iain@sandoe.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).