From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id A1BCA3836C15 for ; Wed, 25 Nov 2020 10:37:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A1BCA3836C15 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 6563CAEC8A; Wed, 25 Nov 2020 11:37:42 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MUSQMwpNivUn; Wed, 25 Nov 2020 11:37:42 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddb2f4.dip0.t-ipconnect.de [79.221.178.244]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id BC4C2AEAB3; Wed, 25 Nov 2020 11:37:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1606300662; bh=/wkMT0iH8yRW5DwK4e0Gpl7E7+qB7+Ox4tFCjiLKDg8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WQ6/sgFB+J9T0V6Rzx+3/c/XRau9KgUSLOEI0H2E1WRWUhsSgVLwgY9rdGeR4H8UA oo4EaL9pX5K22G/gl1P7CumzxDMJj9zZ2jtlBtpVWn9x1+vN8MkKYBqWTVBFj2eJKB EQ2fpLmv1xpuSRFjUpHu5W07wnZmKkXVDLNqxZYKG56dmIe4IE/gnZeJ5R4GOWqZam hqDHV+A1/Y7FjcMM/XMtaVnpSVyWFJaDncgllUztkUzMzPRRKDqkNcm4V6odjdYWvh GTjZEBec9dRhXiC/B0SznBlzdSXC+glKh8I1s0pdJqPE+xoIVio/BE8jI9NuhHmL0u /QJLl96mw1oJQ== From: Rainer Orth To: Iain Sandoe Cc: GCC Patches , David Edelsohn , Andrew Stubbs Subject: Re: [PATCH] configury : Fix LEB128 support for non-GNU assemblers. In-Reply-To: <0099CE62-D849-40BA-BCBD-1AD3882AA9AD@sandoe.co.uk> (Iain Sandoe's message of "Wed, 25 Nov 2020 09:49:58 +0000") References: <0099CE62-D849-40BA-BCBD-1AD3882AA9AD@sandoe.co.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) Date: Wed, 25 Nov 2020 11:37:33 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3791.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2020 10:37:45 -0000 Hi Iain, > I=E2=80=99ve had this patch in my Darwin trees for (literally) years, it = is > relevant to > the GCC ports that use a non-binutils assembler. > > At present, even if such an assembler supports LEB128, the GCC config > is setting HAVE_LEB128 =3D 0. > > The ports I know of that can benefit from a change here are: [...] > Solaris (bootstrapped and tests running on GCC211, but maybe Rainer would > want wider checks). I've just manually tried the augmented test on Solaris 10-11.4, SPARC and x86. While the Solaris/SPARC assembler handles it just fine, the x86 one chokes in a known way: Assembler:=20 "/homes/ro/leb128.s", line 2 : Syntax error Near line: " .uleb128 L2 - L1" > I guess we could exclude specific ports that don=E2=80=99t want to use le= b128 with > a target elif in the configuration. I'll include the patch in tonight's Solaris bootstraps for good measure, but it seems fine to me as is. Thanks. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University