From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org,
Iain Sandoe <idsandoe@googlemail.com>
Subject: Re: [PATCH] libstdc++: Fix error shown during Solaris build
Date: Mon, 16 Nov 2020 12:46:34 +0100 [thread overview]
Message-ID: <ydd4klpy15x.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <20201116103240.GS503596@redhat.com> (Jonathan Wakely's message of "Mon, 16 Nov 2020 10:32:40 +0000")
Hi Jonathan,
>>> libstdc++-v3/ChangeLog:
>>>
>>> * src/Makefile.am (libstdc++-symbols.ver-sun): Remove -lrt from
>>> arguments passed to make_sunver.pl script.
>>> * src/Makefile.in: Regenerate.
>>>
>>> Tested sparc-solaris2.11. Rainer, does this look OK?
>>
>>it does, but let me give it a try with both GNU sed and Solaris sed: we
>>had too many weird issues with the latter ;-(
>
> I think the machine I tested on (gcc211 in the compile farm) only has
> Solaris sed in the PATH, and it works there.
I've now tested the patch on Solaris 11.3 with all of /bin/sed,
/usr/xpg4/bin/sed, and /usr/gnu/bin/sed. Worked perfectly fine, so the
patch is ok, thanks for taking care of this.
> I did try to use "-l ?[[:alnum:]]+" but Solaris sed only supports BREs
> (as POSIX requires) and there doesn't seem to be an equivalent of the
> GNU sed -E option to use EREs.
Indeed, and that hasn't changed in Solaris 11.4 either.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2020-11-16 11:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 11:07 Jonathan Wakely
2020-11-13 11:16 ` Jonathan Wakely
2020-11-13 11:22 ` Iain Sandoe
2020-11-16 10:23 ` Rainer Orth
2020-11-16 10:28 ` Jonathan Wakely
2020-11-16 10:17 ` Rainer Orth
2020-11-16 10:32 ` Jonathan Wakely
2020-11-16 10:37 ` Jonathan Wakely
2020-11-16 11:47 ` Rainer Orth
2020-11-16 11:46 ` Rainer Orth [this message]
2020-11-16 11:54 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd4klpy15x.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=idsandoe@googlemail.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).