From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 482433857829; Mon, 16 Nov 2020 11:46:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 482433857829 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 04E9BCE06; Mon, 16 Nov 2020 12:46:36 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V4XAgGbWyaqM; Mon, 16 Nov 2020 12:46:35 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddb2f4.dip0.t-ipconnect.de [79.221.178.244]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 50903CAC3; Mon, 16 Nov 2020 12:46:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1605527195; bh=+vEyAPLpxf9oDLJChg5zbRX/dVgfnIpHLDDvyrZTJZ4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TcCLz/kDkU85UfUI8e9Fz8WAYfQZnGReiC106hA5XsdD5rMWY9BTUAA39R0wxbejd FUSQxiUY+kufrvScKnuGqRpreFR84lSHUWq54nCm81I1odS0OnIrr9aqJy5o0oC83W oJTA+cHlr3KkfaUEJkngagj3VrXF4MAgxGw2UEJP/Mz76QmFp8gtAmEorjy6+m4VjL K0ILXblIM0rvWhAO3t58fb/NP59e7FffYxCWfNFQWLrFj77levMKYY/m6+8OReWRVF p0II4Gfa8vFpSrvexpUrLQcq+5OZl3gKRoMrq5g6bSV1a5FAUv6TtNnjGMjfcLON8d ygrPtSiEQk5UA== From: Rainer Orth To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, Iain Sandoe Subject: Re: [PATCH] libstdc++: Fix error shown during Solaris build References: <20201113110735.GA505111@redhat.com> <20201116103240.GS503596@redhat.com> Date: Mon, 16 Nov 2020 12:46:34 +0100 In-Reply-To: <20201116103240.GS503596@redhat.com> (Jonathan Wakely's message of "Mon, 16 Nov 2020 10:32:40 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3790.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2020 11:46:38 -0000 Hi Jonathan, >>> libstdc++-v3/ChangeLog: >>> >>> * src/Makefile.am (libstdc++-symbols.ver-sun): Remove -lrt from >>> arguments passed to make_sunver.pl script. >>> * src/Makefile.in: Regenerate. >>> >>> Tested sparc-solaris2.11. Rainer, does this look OK? >> >>it does, but let me give it a try with both GNU sed and Solaris sed: we >>had too many weird issues with the latter ;-( > > I think the machine I tested on (gcc211 in the compile farm) only has > Solaris sed in the PATH, and it works there. I've now tested the patch on Solaris 11.3 with all of /bin/sed, /usr/xpg4/bin/sed, and /usr/gnu/bin/sed. Worked perfectly fine, so the patch is ok, thanks for taking care of this. > I did try to use "-l ?[[:alnum:]]+" but Solaris sed only supports BREs > (as POSIX requires) and there doesn't seem to be an equivalent of the > GNU sed -E option to use EREs. Indeed, and that hasn't changed in Solaris 11.4 either. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University