From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 6DD2F385B835; Fri, 10 Apr 2020 12:14:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6DD2F385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 3B236ECE38; Fri, 10 Apr 2020 14:14:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FXfEiPawIOgt; Fri, 10 Apr 2020 14:14:11 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4FDDBA1F.dip0.t-ipconnect.de [79.221.186.31]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 70428ED304; Fri, 10 Apr 2020 14:14:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1586520851; bh=R37L0t+DQR5H/8m7Le7R8psn3LKnYHHcocWL4GeIITQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kxcG9tYbndvwdwBkLEWmDGOGk/DvXEb5i37e3/BQ2CVOufLUSR8svg//pBK2+kGBY XJ06IDY5sJCjjODksFuAOiI868QV+ds95bCASJXuwbGIhm/uDBXU9pJOeLegYFZiiU I1BRL8VqisbxP5REKM9qMa79kuI5BHkKodFWddmiezjJljC2gGs/eh9x9aesKVRWam OT0S9x8NgBp9ZtHC3BBtBzPypBCeCsC2WoKkHeW2ddzX5wU/zbeayUx20ZH+2pujzd 0IHxzebv26ORxHzdj+wsj8/FCxmt2F/5adfcGoEQdTWwaFl7HARBzJ3iRw1M8KVMSw QS3DkJs0OnrLQ== From: Rainer Orth To: Fritz Reese via Gcc-patches Cc: Tobias Burnus , Fritz Reese , fortran Subject: Re: [PATCH, Fortran] -- PR fortran/87923 -- fix ICE when resolving I/O tags and simplify io.c References: Date: Fri, 10 Apr 2020 14:14:10 +0200 In-Reply-To: (Fritz Reese via Gcc-patches's message of "Thu, 9 Apr 2020 16:59:37 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2020 12:14:15 -0000 Hi Fritz, > Thanks very much for the review. > > On Thu, Apr 9, 2020 at 5:21 AM Tobias Burnus wr= ote: >> >> Hi, >> >> On 4/6/20 7:25 PM, Fritz Reese via Fortran wrote: >> >> > The attached patch fixes PR 87923 while also simplifying the code in >> > io.c. >> >> Thanks for the work, which looks great; it is a bit lengthy >> but mostly moving code or mechanical (%C =E2=86=92 %L). >> It also has an impressive amount of new test cases! > > I also wished the patch could be easier on the eyes, but alas > sometimes this is the price of progress. :-) > >> * First line in git commit "Fix fortran/87923 -- ICE(s) when resolving >> I/O tags." >> It helps with doing patch archeology if they are the same =E2=80=93 o= r if the >> GIT one >> is a substring of the email subject. (If it is about a PR, searching >> for the PR >> usually works, but also not al emails have the PR number in the subje= ct.) >> For this patch, you use: >> email: "[PATCH, Fortran] -- PR fortran/87923 -- fix ICE when resolving >> I/O tags and simplify io.c" >> GIT: "Fix fortran/87923 -- ICE(s) when resolving I/O tags." > > Yes, that is a good point. I will alter the commit summary to match > the email subject. > >> * Please check whether the ChangeLog lines are too long; I didn't count >> but it looks as if they might be too long. For sure, they >> were too long for your mail program =E2=80=A6 > > I copied the git commit message from the log, which git formats with > an extra level of indentation. I wrapped the raw ChangeLog entries and > commit message to 80 characters, but after the extra indentation my > mail client indeed wrapped the lines during post-processing. I suppose > I should wrap these each to 76 to account for git's indentation. That > certainly makes "git log" look better. > >> * In the following comment, you have two empty tailing lines: >> >> + Tag expressions are already resolved by resolve_tag, which includes >> + verifying the type, that they are scalar, and verifying that BT_CHAR= ACTER >> + tags are of default kind. >> + >> + */ > > Oops! > > > I will commit the patch with these fixes rebased on master after one > final build+test. Thanks again for taking a look. one new testcases comes up as UNRESOLVED everywhere: +UNRESOLVED: gfortran.dg/asynchronous_5.f03 -O scan-tree-dump-not origi= nal "volatile.*?ivar_noasync" +UNRESOLVED: gfortran.dg/asynchronous_5.f03 -O scan-tree-dump-times ori= ginal "volatile.*?ccvar_async" 1 +UNRESOLVED: gfortran.dg/asynchronous_5.f03 -O scan-tree-dump-times ori= ginal "volatile.*?darrvar_async" 1 +UNRESOLVED: gfortran.dg/asynchronous_5.f03 -O scan-tree-dump-times ori= ginal "volatile.*?dvar_async" 1 +UNRESOLVED: gfortran.dg/asynchronous_5.f03 -O scan-tree-dump-times ori= ginal "volatile.*?ivar_async" 1 +UNRESOLVED: gfortran.dg/asynchronous_5.f03 -O scan-tree-dump-times ori= ginal "volatile.*?lvar_async" 1 +UNRESOLVED: gfortran.dg/asynchronous_5.f03 -O scan-tree-dump-times ori= ginal "volatile.*?rvar_async" 1 gfortran.dg/asynchronous_5.f03 -O : dump file does not exist It has several scan-tree-dump* checks, but no corresponding -fdump-tree-* option. Please fix (and make sure not to look only for FAILs during regtesting in the future). Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University