public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Richard Sandiford <rdsandiford@googlemail.com>
Subject: Re: [doc] Remove references to mips-tfile on MIPS
Date: Tue, 26 Apr 2011 16:53:00 -0000	[thread overview]
Message-ID: <ydd4o5lm27o.fsf@manam.CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <Pine.LNX.4.64.1104211636290.17540@digraph.polyomino.org.uk>	(Joseph S. Myers's message of "Thu, 21 Apr 2011 16:44:31 +0000 (UTC)")

Joseph,

> Not strictly related to this patch, but there are other cleanups possible 
> because of the only-used-on-Tru64 nature of mips-tdump/mips-tfile.  In 
> particular, there are seven target macros (all undocumented) used by those 
> programs and nowhere else in GCC: ALIGN_SYMTABLE_OFFSET CODE_MASK 
> MIPS_IS_STAB MIPS_MARK_STAB MIPS_UNMARK_STAB SHASH_SIZE THASH_SIZE.  
> Since those are only defined in alpha.h and only used on those programs, 
> it would be better to hardcode the definitions inside 
> mips-{tdump,tfile}.c, remove them from alpha.h and so eliminate seven 
> target macros (about 1% of the total).  If you also hardcode the right 
> definition of MIPS_DEBUGGING_INFO (used both in mips-tfile and elsewhere) 
> then these programs should no longer depend on target macros and their 
> tm.h includes can be removed.

seems like a plan.  I'll have a look, especially since several of the
macros are only used in either mips-tfile.c or mips-tdump.c, so such a
patch wouldn't introduce much duplication.

> (There are many other instances of #if conditionals in those programs, all 
> of which are suspect since the programs are native-only for a single 
> target and so shouldn't need conditional compilation at all.  But those 
> other conditionals aren't relevant to target macro elimination.)

I strongly suspect this occured when the MIPS port no longer needed
mips-tfile, but didn't remove MIPS dependencies.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

      reply	other threads:[~2011-04-26 16:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-14 20:13 Rainer Orth
2011-04-14 21:56 ` Richard Sandiford
2011-04-21 17:27 ` Joseph S. Myers
2011-04-26 16:53   ` Rainer Orth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ydd4o5lm27o.fsf@manam.CeBiTec.Uni-Bielefeld.DE \
    --to=ro@cebitec.uni-bielefeld.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=rdsandiford@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).