From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 814053858414 for ; Wed, 8 Sep 2021 11:31:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 814053858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 1D47BBF342; Wed, 8 Sep 2021 13:31:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wBmVHWuLEckz; Wed, 8 Sep 2021 13:31:23 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p5085556f.dip0.t-ipconnect.de [80.133.85.111]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 6E831BF524; Wed, 8 Sep 2021 13:31:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1631100683; bh=OJPv+x2ADJ8Ci6CE7MMYA9V0qzIJNOnPeCtgu/TlO3M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZCL9ekQNAsMS1zIPHfUTqViRaLH6U9pSSF4sWRI019YsQA5VJNVvYuDMg279F5456 5p592niwqI68OqKPv9ZliShBS6QyVW7im473qEEZS3YttIML9J5ZBEpMiAUMWuGYF3 aYQ0+gC6hLQWGHwckdSeEd0Ms0bRGzKhBfODmIGEZLtcrCAlTtAX3SHrZuhOf6da4T PPw1jKqbcA4mnZFziNMqcspC4LXe9SQtrO1ZFlBc+kQS8R5m5sxAb5/trcJWCwFhmA SEAWdfwkwg9OQFgwgfhUTFmDZ0HdagRGdVQcXTje90HDkUyeyQTV5u4ud2mHmbtx5Q hZ9WJXytr774w== From: Rainer Orth To: Hans-Peter Nilsson via Gcc-patches Cc: Martin Liaka , Hans-Peter Nilsson Subject: Re: [Committed] Fix fatal typo in gcc.dg/no_profile_instrument_function-attr-2.c References: <4a46257d-91cd-427e-1b11-7599ad36d07f@suse.cz> <20210623123841.GC65660@kam.mff.cuni.cz> <7fed627d-7213-918c-3ca6-0db60623a32b@suse.cz> <20210907204154.9F4CB203AE@pchp3.se.axis.com> <0f3a38aa-66bd-7c52-72fa-b15666a6ff98@suse.cz> <20210908112514.2897B203AE@pchp3.se.axis.com> Date: Wed, 08 Sep 2021 13:31:22 +0200 In-Reply-To: <20210908112514.2897B203AE@pchp3.se.axis.com> (Hans-Peter Nilsson via Gcc-patches's message of "Wed, 8 Sep 2021 13:25:14 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3788.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 11:31:27 -0000 Hi Hans-Peter, >> From: Martin Liaka >> Date: Wed, 8 Sep 2021 09:29:52 +0200 > >> On 9/7/21 22:41, Hans-Peter Nilsson wrote: >> > With r12-3379, the testsuite got such a fatal syntax error, >> > causing the gcc test-run to abort at (e.g.): >> >> Thank you for the fix! I haven't noticed the problem as I only grep for '^FAIL' >> lines in the corresponding log files. > > You're welcome but *please* also add (conceptually) > "grep -q ^ERROR: makelog && fail" to your workflow. even that is not enough, though: one also needs to look for UNRESOLVED and XPASS. An easy way of doing all this is running make mail-report.log after the build and comparing the output to an unmodified build. Saves everyone loads of trouble. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University