From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: "Martin Liška" <mliska@suse.cz>
Cc: Uros Bizjak <ubizjak@gmail.com>, Jakub Jelinek <jakub@redhat.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Richard Guenther <richard.guenther@gmail.com>,
renlin.li@foss.arm.com,
"gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Come up with gcc/testsuite/g++.target/i386/i386.dg and move there some tests.
Date: Fri, 12 Oct 2018 09:27:00 -0000 [thread overview]
Message-ID: <ydd7einshi0.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <64ea102f-2686-3a45-30e9-81acf4097de4@suse.cz> ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Tue, 9 Oct 2018 13:41:39 +0200")
Hi Martin,
> On 10/9/18 11:03 AM, Rainer Orth wrote:
>> Hi Martin,
>>
>>> rename from gcc/testsuite/g++.dg/ext/pr82625.C
>>> rename to gcc/testsuite/g++.target/i386/pr82625.C
>>> index 59b174f8c51..0eb70baed5e 100644
>>> --- a/gcc/testsuite/g++.dg/ext/pr82625.C
>>> +++ b/gcc/testsuite/g++.target/i386/pr82625.C
>>> @@ -1,7 +1,7 @@
>>> /* { dg-do compile } */
>>> /* { dg-require-ifunc "" } */
>>> /* { dg-options "-O2 -fdump-tree-optimized" } */
>>> -/* { dg-do compile { target i?86-*-* x86_64-*-* } } */
>>> +/* { dg-do compile } */
>>
>> this is wrong: two instances of dg-do and dg-do after target selections
>> don't play well with one another. When you added it yesterday, you
>> badly broke the test on all x86 targets without ifunc support (probably
>> everything non-Linux):
>>
>> +UNRESOLVED: g++.dg/ext/pr82625.C -std=gnu++11 scan-tree-dump-times
>> optimized "return 4096;" 1
>> +UNRESOLVED: g++.dg/ext/pr82625.C -std=gnu++11 scan-tree-dump-times
>> optimized "return 8192;" 1
>> +FAIL: g++.dg/ext/pr82625.C -std=gnu++11 (test for excess errors)
>>
>> Excess errors:
>> /vol/gcc/src/hg/trunk/local/gcc/testsuite/g++.dg/ext/pr82625.C:7:17:
>> error: multiversioning needs ifunc which is not supported on this target
>> /vol/gcc/src/hg/trunk/local/gcc/testsuite/g++.dg/ext/pr82625.C:24:1:
>> error: use of multiversioned function without a default
>>
>> Just remove the second dg-do line.
>
> Thanks for testing!
>
> I'm sending updated version of the patch.
I noticed that before the tests were run with all of
-std=(c|gnu)++(98|11|14), now with no explict -std option. I wonder if
this is an issue.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2018-10-12 8:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 14:12 [PATCH] Redirect call within specific target attribute among MV clones (PR ipa/82625) Martin Liška
2018-10-04 14:34 ` Jeff Law
2018-10-04 14:58 ` Martin Liška
2018-10-08 9:16 ` Renlin Li
2018-10-08 10:06 ` Martin Liška
2018-10-08 10:11 ` Richard Earnshaw (lists)
2018-10-08 10:29 ` Martin Liška
2018-10-08 10:34 ` Richard Biener
2018-10-08 10:46 ` Martin Liška
2018-10-08 10:55 ` Jakub Jelinek
2018-10-08 11:01 ` Martin Liška
2018-10-08 11:14 ` Richard Earnshaw (lists)
2018-10-08 11:29 ` [PATCH] Come up with gcc/testsuite/g++.target/i386/i386.dg and move there some tests Martin Liška
2018-10-08 11:33 ` Jakub Jelinek
2018-10-08 11:47 ` Uros Bizjak
2018-10-08 12:49 ` Martin Liška
2018-10-08 13:21 ` Uros Bizjak
2018-10-09 9:52 ` Martin Liška
2018-10-09 10:06 ` Rainer Orth
2018-10-09 11:44 ` Martin Liška
2018-10-12 9:27 ` Rainer Orth [this message]
2018-10-22 10:24 ` Martin Liška
2018-10-22 10:31 ` Jakub Jelinek
2018-10-22 13:08 ` Martin Liška
2018-11-16 17:01 ` Renlin Li
2018-11-20 12:08 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd7einshi0.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mliska@suse.cz \
--cc=renlin.li@foss.arm.com \
--cc=richard.guenther@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).