From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30491 invoked by alias); 20 Jun 2017 13:01:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30452 invoked by uid 89); 20 Jun 2017 13:01:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-19.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=ville X-Spam-User: qpsmtpd, 3 recipients X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 13:01:56 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id EA71E633; Tue, 20 Jun 2017 15:01:52 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XzrK6e9pt+5F; Tue, 20 Jun 2017 15:01:50 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id ACD89631; Tue, 20 Jun 2017 15:01:50 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id v5KD1oxw004439; Tue, 20 Jun 2017 15:01:50 +0200 (MEST) From: Rainer Orth To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, fortran@gcc.gnu.org, Uros Bizjak , Jonathan Yong <10walls@gmail.com>, Mike Stump Subject: Re: [testsuite, i386] Always check for target i?86 and x86_64 References: <20170615113104.GP2958@redhat.com> Date: Tue, 20 Jun 2017 13:01:00 -0000 In-Reply-To: <20170615113104.GP2958@redhat.com> (Jonathan Wakely's message of "Thu, 15 Jun 2017 12:31:04 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01451.txt.bz2 Hi Jonathan, > On 15/06/17 12:51 +0200, Rainer Orth wrote: >>I happened to notice that recently a couple of testcases have sneaked in >>that are restricted to x86_64-*-* targets only. This is always wrong: >>it should be i?86-*-* and x86_64-*-* alike, eventually restricing the >>test to ilp32 or lp64. There were also instances of i?86-*-* only, >>which I've handled as well. > > [...] > >>diff --git a/libstdc++-v3/testsuite/20_util/variant/index_type.cc >> b/libstdc++-v3/testsuite/20_util/variant/index_type.cc >>--- a/libstdc++-v3/testsuite/20_util/variant/index_type.cc >>+++ b/libstdc++-v3/testsuite/20_util/variant/index_type.cc >>@@ -1,5 +1,5 @@ >> // { dg-options "-std=gnu++17" } >>-// { dg-do compile { target x86_64-*-* powerpc*-*-* } } >>+// { dg-do compile { target i?86-*-* x86_64-*-* powerpc*-*-* } } >> >> // Copyright (C) 2017 Free Software Foundation, Inc. >> // > > The concern here was just that we don't want the test to fail on > targets with weird integer sizes, so the list of targets was > restricted to just those where Ville had tested it. > > But { target ilp32 lp64 } would surely be fine. The test will only > fail if a struct with two char-sized subobjects is the same size as > size_t. Feel free to change it to { target ilp32 lp64 }. once I got the syntax right, this worked fine: it needs { target { ilp32 || lp64 } } instead ;-) I've also now managed to complete a Darwin/x86_64 bootstrap by locally reverting the two culprit patches for PR bootstrap/81033 and confirmed that the patched testcases are fine there, two. Given that there were no other comments, I've installed the patch. It would still be nice if the Cygwin/MingW maintainer could comment on the testcase situation for those targets. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University