From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105113 invoked by alias); 11 Nov 2016 17:01:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105078 invoked by uid 89); 11 Nov 2016 17:01:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=don=a1=aft, H*c:gb2312, Hx-languages-length:1771, 10.7?= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Nov 2016 17:01:12 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 84191F28; Fri, 11 Nov 2016 18:01:10 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cRDAUYNh6wLy; Fri, 11 Nov 2016 18:01:08 +0100 (CET) Received: from fuego.CeBiTec.Uni-Bielefeld.DE (p5DCE00AF.dip0.t-ipconnect.de [93.206.0.175]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 3040EF27; Fri, 11 Nov 2016 18:01:08 +0100 (CET) From: Rainer Orth To: Iain Sandoe Cc: GCC Patches , Bruce Korb Subject: Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267) References: <5D0F34A7-12A8-4DEC-915A-4BE37CFD76A1@comcast.net> <9DDB7AF3-3836-4E89-AA5E-2A142E37FE31@mentor.com> <6E40427C-6B52-4219-94AA-02B1019009FE@mentor.com> Date: Fri, 11 Nov 2016 17:01:00 -0000 In-Reply-To: <6E40427C-6B52-4219-94AA-02B1019009FE@mentor.com> (Iain Sandoe's message of "Fri, 11 Nov 2016 16:58:07 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg01145.txt.bz2 Hi Iain, >> On 11 Nov 2016, at 16:50, Rainer Orth wrot= e: >>=20 >> Hi Iain, >>=20 >>>> On 11 Nov 2016, at 11:18, Mike Stump wrote: >>>>=20 >>>> On Nov 11, 2016, at 2:15 AM, Rainer Orth >>>> wrote: >>>>> The patch passes fixincludes make check (this time for real ;-) and >>>>> restores macOS 10.12 bootstrap. >>>>=20 >>>> No objections from me. >>>=20 >>> On x86_64-darwin14, there still seem to be fails >>>=20 >>> /usr/include/os/base.h=20 >>> /usr/include/dispatch/dispatch.h >>> /usr/include/dispatch/object.h >>>=20 >>> of kinds __has_extension() and block syntax. >>>=20 >>> (I haven=A1=AFt had a chance to check any other OS revs yet). >>=20 >> I don't have access to anything but Darwin 11 and 16, so I can't help >> directly. > > OK. Only the dispatch/ ones are present on Darwin11 > > (did that bootstrap OK for you? if so likely 10.6 will be OK too - save = me > checking). 10.7 did without issues. >> Maybe, if you can send (or attach to the PR) the specific >> errors and problematic headers (or point to copies on >> opensource.apple.com), I can help with the fixincludes part. > > I don=A1=AFt have a Darwin16 system live at present, so can=A1=AFt compar= e, but > os/base.h is present on Darwin15 (so i=A1=AFd expect it to be in the Darw= in16 > SDK) It is indeed. > I=A1=AFll see if I can take an initial pass at it over the w/e and post t= o the PR. Fine. I'm sure we can fix Apple's mistakes here, but it would probably help to file bugs with them for everything we find. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University