From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Richard Guenther <richard.guenther@gmail.com>,
Mike Stump <mikestump@comcast.net>,
Mikael Morin <mikael.morin@sfr.fr>,
fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] gfortran testsuite: implicitly cleanup-modules
Date: Mon, 19 Mar 2012 17:36:00 -0000 [thread overview]
Message-ID: <ydd7gygpk6r.fsf@manam.CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <20120316100445.GA30354@mx.loc> (Bernhard Reutner-Fischer's message of "Fri, 16 Mar 2012 11:04:45 +0100")
Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
> On Thu, Mar 15, 2012 at 08:35:47PM +0100, Jakub Jelinek wrote:
>>On Thu, Mar 15, 2012 at 05:56:32PM +0100, Bernhard Reutner-Fischer wrote:
>>> On Thu, Mar 15, 2012 at 04:57:12PM +0100, Richard Guenther wrote:
>>> >On Thu, Mar 15, 2012 at 1:39 PM, Bernhard Reutner-Fischer
>>> ><rep.dot.nop@gmail.com> wrote:
>>>
>>> >> committed as r185430.
>>> >
>>> >You forgot to add fortran-modules.exp :(
>>>
>>> committed as r185439.
>>> I am very sorry for that..
>>
>>Even with that file in, libgomp and libitm make check still fail,
>>can't find fortran-modules.exp.
>
> I have committed the attached as r185460.
Unfortunately, this patch creates a bogus warning in the libgomp
testsuite, which also shows up in mail-report.log:
WARNING: Line 30 includes unreadable file \`/vol/gcc/src/hg/trunk/local/libgomp/testsuite/libgomp.fortran/omp_lib.h'
fortran-modules.exp (list-module-names-1) assumes that included files
are relative to the source, but omp_lib.h is a generated file and lives
in $objdir, and is found at compile time via -I switches.
Besides, the message is less than helpful since it gives no indication
as to which files includes the missing one.
Please fix.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2012-03-19 17:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 21:40 [patch, testsuite, committed] Clean up gfortran.dg leftover module files Brooks Moses
2007-03-26 21:45 ` FX Coudert
2007-03-27 17:24 ` Bernhard Fischer
2007-03-27 17:29 ` Bernhard Fischer
2012-03-01 21:10 ` [PATCH] gfortran testsuite: implicitly cleanup-modules Bernhard Reutner-Fischer
2012-03-09 0:04 ` Mikael Morin
2012-03-13 16:39 ` Bernhard Reutner-Fischer
2012-03-13 20:31 ` Mike Stump
2012-03-15 12:40 ` Bernhard Reutner-Fischer
2012-03-15 15:57 ` Richard Guenther
2012-03-15 16:56 ` Bernhard Reutner-Fischer
2012-03-15 19:36 ` Jakub Jelinek
2012-03-16 10:05 ` Bernhard Reutner-Fischer
2012-03-16 15:00 ` Bernhard Reutner-Fischer
2012-06-29 0:15 ` Bernhard Reutner-Fischer
2012-06-29 0:55 ` Mike Stump
2012-06-29 0:56 ` Bernhard Reutner-Fischer
2012-06-29 5:43 ` Mike Stump
2013-06-07 14:30 ` Bernhard Reutner-Fischer
2013-06-10 23:21 ` Ben Elliston
2012-03-19 17:36 ` Rainer Orth [this message]
2012-03-22 12:30 ` Bernhard Reutner-Fischer
2012-04-03 12:17 ` [PATCH] gfortran testsuite: implicitly cleanup-modules, part 2 Bernhard Reutner-Fischer
2012-04-03 12:58 ` Bernhard Reutner-Fischer
2012-04-13 10:51 ` PING " Bernhard Reutner-Fischer
2012-04-13 13:58 ` Mike Stump
2012-04-13 14:40 ` Bernhard Reutner-Fischer
2012-04-13 20:09 ` Mike Stump
2012-04-13 14:15 ` Mike Stump
2015-04-23 8:55 ` [PATCH] gfortran testsuite: implicitly cleanup-modules Bernhard Reutner-Fischer
2015-04-29 21:58 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd7gygpk6r.fsf@manam.CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mikael.morin@sfr.fr \
--cc=mikestump@comcast.net \
--cc=rep.dot.nop@gmail.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).