Re: [PING] PR middle-end/95126: Expand small const structs as immediate constants

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

Hi Roger,

>> I just tried this on i386-pc-solaris2.11: unfortunately, it made no
> difference.
>
> Awesome!  Very many thanks for trying this.  Alas it confirms that the patch
> I'm currently spinning won't have any affect.  So by a process of
> elimination,
> the miscompilation must be triggered by one of the other two changes:
>
> diff --git a/gcc/expr.cc b/gcc/expr.cc
> index fb062dc..37f1405 100644
> --- a/gcc/expr.cc
> +++ b/gcc/expr.cc
> @@ -4871,7 +4871,7 @@ emit_push_insn (rtx x, machine_mode mode, tree type,
> rtx s
>           /* If source is a constant VAR_DECL with a simple constructor,
>               store the constructor to the stack instead of moving it.  */
>           const_tree decl;
> -         if (partial == 0
> +         if (0 && partial == 0
>               && MEM_P (xinner)
>               && SYMBOL_REF_P (XEXP (xinner, 0))
>               && (decl = SYMBOL_REF_DECL (XEXP (xinner, 0))) != NULL_TREE
> @@ -10603,7 +10603,7 @@ expand_expr_real_1 (tree exp, rtx target,
> machine_mode t
>         }
>        /* Expand const VAR_DECLs with CONSTRUCTOR initializers that
>          have scalar integer modes to a reg via store_constructor.  */
> -      if (TREE_READONLY (exp)
> +      if (0 && TREE_READONLY (exp)
>           && !TREE_SIDE_EFFECTS (exp)
>           && (modifier == EXPAND_NORMAL || modifier == EXPAND_STACK_PARM)
>           && immediate_const_ctor_p (DECL_INITIAL (exp))

I've tried both chunks individually: the second one allowed the build to
finish successfully.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University