From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 488B3386EC43 for ; Mon, 11 Jan 2021 12:11:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 488B3386EC43 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id CB3F967A43; Mon, 11 Jan 2021 13:11:02 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dsc3zkvSpXXq; Mon, 11 Jan 2021 13:11:02 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50854446.dip0.t-ipconnect.de [80.133.68.70]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 5FE8A675D5; Mon, 11 Jan 2021 13:11:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1610367062; bh=yq5C0lE5BdlkOl89ec/yUEITsxdlJ0zhvfTK+M6h0+I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SPfuaRDfo4yp7kO1V5hTHOv/pxflLo9h+vJyRedJ2igipTmlPzzSa1zstp0jnGG4R K7VNg9jVzXmECV+DO/pxzS9blpYHp+JVPCDBdoPY3+fgeGtN4RwOqRPqh6YyqZNMT6 B20ElgkfDwpcpPY8ydgziyPhGSRYIwgNmsVLTxuvwCBaoKOOAxCwZDRZaSPFU4qzaf rnHI/HvU2lo1Bj2uciB2lp+TJP0spi7FLKWUope5TzsU37eXaDKskyiQwIXsIbE2f8 BiOoTpgvz85Ok+oIDPDV7o4P5oIgb6V7JBah3uTYuSPY/oxGCShx9wwi/DvzXrioYG tC6QOyMAEhwSg== From: Rainer Orth To: Alexandre Oliva Cc: Bernd Edlinger , "gcc-patches@gcc.gnu.org" , Mike Stump , David Edelsohn Subject: Re: [PATCH] testsuite: Fix test failures from outputs.exp [PR98225] References: Date: Mon, 11 Jan 2021 13:11:01 +0100 In-Reply-To: (Alexandre Oliva's message of "Fri, 08 Jan 2021 05:52:32 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3789.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 12:11:05 -0000 Hi Alexandre, > On Jan 7, 2021, Bernd Edlinger wrote: > >> I don't know why that is there in the first place, as there >> are no C++ test cases, these files should not be created at all. > > collect2, on platforms that use it, create .cdtor files even for C. > David Edelsohn told me so back then; the problem was on AIX IIRC. That > was why I added code to tolerate such outputs. Removing it would likely > bring that failure back. > > >> Is it OK for trunk? > > It looks good to me, aside from the removal of the .cdtor handler. > > I don't think I have authority to approve it with that change, > but I would if I did ;-) Thanks! that's exactly the kind of feedback I've been hoping for ;-) Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University