From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 3B0D6382FADF; Fri, 28 Jun 2024 11:50:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B0D6382FADF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3B0D6382FADF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719575440; cv=none; b=YMQ9e7rrqVJyo1hu7hHn/goAsOmcttIM1OdlYxfmIniAc6vRE5yxcvDpnZ39FMrd8cT2qkZ2+LHeuyjFl0tkxYU64Pthyv3phYq9EE2GFVawmWPGqMdtqB4FjWZpQ7359X8PxajWgg5Rcss6+dsq63wl29EwiBqlYoV5POi2+Uc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719575440; c=relaxed/simple; bh=CdhXqlgXmJaqvHqX4nMZK6dSPSqrFdddpZlGxW7Mg8I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VQnAVjWglw0Pg3HSgLuqaHDZvJDNfzp1bWQJAqeasfHeAt/w9cRiKQyUc4MbEJQyhh2PU7T89v47+KY3E5kl7FwES0x0+C3GOHql5vyiMaVhiica4BhDYa4SHERWT1oZUaCq7/gvgD7PUsf3CgWWuona3lummOQ23UHHXX1s9H4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 27002BDA26; Fri, 28 Jun 2024 13:50:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-type:content-type :mime-version:user-agent:message-id:in-reply-to:date:date :references:subject:subject:from:from:received:received; s= 20200306; t=1719575436; bh=CdhXqlgXmJaqvHqX4nMZK6dSPSqrFdddpZlGx W7Mg8I=; b=ltzXQ3lB3TYXLjNSUJh8gwhdGE+R/aEDaWVJRlV19zf9Y3Od1cUux e67bi38/Up+d80DfJByvWk/JFpsHgfvwScxljCpuYuTgGFUxxT98k0B9tMnUTNpc 2HzsNrrF+vI6KMZx9CBgVi8MI1nq/M+XxJP937AGrUQGeZVn3auLGmWeUPx+PE+5 LbPQoLFUcWYIdUV7j3XoMWcModrTrX0V4EkAhzlTq362zYy9o+Ek53ZRjFQBMDux oqgSdW8cY7g6YPzzfvc+7+Z4DWg1NJy11L0TGjvZ9u0iRXe6qyVxL5fchUgHZyK3 ZrDR/BvmSOsiZ06ewmL1z8TZilxEEHlNw== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 15bBSwRQr0bE; Fri, 28 Jun 2024 13:50:36 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddb173.dip0.t-ipconnect.de [79.221.177.115]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 98155BD165; Fri, 28 Jun 2024 13:50:36 +0200 (CEST) From: Rainer Orth To: David Malcolm Cc: Antoni Boucher , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" Subject: Re: [PATCH] libgccjit: Add ability to get the alignment of a type References: <0f5dc195-1148-4a70-b730-18eaa8ba4000@zoho.com> Date: Fri, 28 Jun 2024 13:50:36 +0200 In-Reply-To: (David Malcolm's message of "Wed, 26 Jun 2024 11:16:43 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3780.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_ASCII_DIVIDERS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: David Malcolm writes: > On Thu, 2024-04-04 at 18:59 -0400, Antoni Boucher wrote: >> Hi. >> This patch adds a new API to produce an rvalue representing the >> alignment of a type. >> Thanks for the review. > > Patch looks good to me (but may need the usual ABI version updates when > merging). This patch broke macOS bootstrap: /vol/gcc/src/hg/master/darwin/gcc/jit/jit-recording.cc: In member function 'virtual gcc::jit::recording::string* gcc::jit::recording::memento_of_typeinfo::make_debug_string()': /vol/gcc/src/hg/master/darwin/gcc/jit/jit-recording.cc:5529:30: error: 'ident' may be used uninitialized [-Werror=maybe-uninitialized] 5529 | return string::from_printf (m_ctxt, | ~~~~~~~~~~~~~~~~~~~~^~~~~~~~ 5530 | "%s (%s)", | ~~~~~~~~~~ 5531 | ident, | ~~~~~~ 5532 | m_type->get_debug_string ()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /vol/gcc/src/hg/master/darwin/gcc/jit/jit-recording.cc:5519:15: note: 'ident' was declared here 5519 | const char* ident; | ^~~~~ /vol/gcc/src/hg/master/darwin/gcc/jit/jit-recording.cc: In member function 'virtual void gcc::jit::recording::memento_of_typeinfo::write_reproducer(gcc::jit::reproducer&)': /vol/gcc/src/hg/master/darwin/gcc/jit/jit-recording.cc:5552:11: error: 'type' may be used uninitialized [-Werror=maybe-uninitialized] 5552 | r.write (" gcc_jit_rvalue *%s =\n" | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ 5553 | " gcc_jit_context_new_%sof (%s, /* gcc_jit_context *ctxt */\n" | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 5554 | " (gcc_jit_type *) %s); /* gcc_jit_type *type */\n", | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 5555 | id, | ~~~ 5556 | type, | ~~~~~ 5557 | r.get_identifier (get_context ()), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 5558 | r.get_identifier (m_type)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~ /vol/gcc/src/hg/master/darwin/gcc/jit/jit-recording.cc:5541:15: note: 'type' was declared here 5541 | const char* type; | ^~~~ I wonder how this can have worked anywhere (apart from jit not being enabled by default on non-Darwin targets). Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University