* Pass GDCFLAGS and CCASFLAGS to libphobos subdirs
@ 2018-12-07 13:30 Rainer Orth
2018-12-07 19:12 ` Iain Buclaw
0 siblings, 1 reply; 2+ messages in thread
From: Rainer Orth @ 2018-12-07 13:30 UTC (permalink / raw)
To: gcc-patches; +Cc: Iain Buclaw
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
When trying to rebuild libphobos with -g3 -O0 for better debugging, I
noticed that GDCFLAGS weren't passed down as expected. It turned out
that they are missing from AM_MAKEFLAGS. After I fixed this, the only
file still compiled with -g -O2 was libdruntime/core/threadasm.S, so I
added CCASFLAGS, too.
Tested on i386-pc-solaris2.11. Ok for mainline?
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
2018-12-06 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* Makefile.am (AM_MAKEFLAGS): Pass CCASFLAGS, GDCFLAGS.
* Makefile.in: Regenerate.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: libphobos-gdcflags-subdirs.patch --]
[-- Type: text/x-patch, Size: 724 bytes --]
# HG changeset patch
# Parent 5910a51aed6e6de5841187a79b17799d6e2241b5
Pass GDCFLAGS and CCASFLAGS to libphobos subdirs
diff --git a/libphobos/Makefile.am b/libphobos/Makefile.am
--- a/libphobos/Makefile.am
+++ b/libphobos/Makefile.am
@@ -29,12 +29,14 @@ AM_MAKEFLAGS = \
"AR_FLAGS=$(AR_FLAGS)" \
"CC_FOR_BUILD=$(CC_FOR_BUILD)" \
"CC_FOR_TARGET=$(CC_FOR_TARGET)" \
+ "CCASFLAGS=$(CCASFLAGS)" \
"CFLAGS=$(CFLAGS)" \
"CXXFLAGS=$(CXXFLAGS)" \
"CFLAGS_FOR_BUILD=$(CFLAGS_FOR_BUILD)" \
"CFLAGS_FOR_TARGET=$(CFLAGS_FOR_TARGET)" \
"GDC_FOR_TARGET=$(GDC_FOR_TARGET)" \
"GDC=$(GDC)" \
+ "GDCFLAGS=$(GDCFLAGS)" \
"INSTALL=$(INSTALL)" \
"INSTALL_DATA=$(INSTALL_DATA)" \
"INSTALL_PROGRAM=$(INSTALL_PROGRAM)" \
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Pass GDCFLAGS and CCASFLAGS to libphobos subdirs
2018-12-07 13:30 Pass GDCFLAGS and CCASFLAGS to libphobos subdirs Rainer Orth
@ 2018-12-07 19:12 ` Iain Buclaw
0 siblings, 0 replies; 2+ messages in thread
From: Iain Buclaw @ 2018-12-07 19:12 UTC (permalink / raw)
To: ro; +Cc: gcc-patches
On Fri, 7 Dec 2018 at 14:30, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
> When trying to rebuild libphobos with -g3 -O0 for better debugging, I
> noticed that GDCFLAGS weren't passed down as expected. It turned out
> that they are missing from AM_MAKEFLAGS. After I fixed this, the only
> file still compiled with -g -O2 was libdruntime/core/threadasm.S, so I
> added CCASFLAGS, too.
>
> Tested on i386-pc-solaris2.11. Ok for mainline?
>
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2018-12-06 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> * Makefile.am (AM_MAKEFLAGS): Pass CCASFLAGS, GDCFLAGS.
> * Makefile.in: Regenerate.
>
Thanks, looks good to me.
--
Iain
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-07 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-07 13:30 Pass GDCFLAGS and CCASFLAGS to libphobos subdirs Rainer Orth
2018-12-07 19:12 ` Iain Buclaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).