From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Ian Lance Taylor <iant@golang.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"gofrontend-dev\@googlegroups.com"
<gofrontend-dev@googlegroups.com>
Subject: Re: libgo patch committed: Change build procedure to use build tags
Date: Fri, 12 Aug 2016 13:56:00 -0000 [thread overview]
Message-ID: <ydda8gi3xbn.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <yddvaz64acb.fsf@CeBiTec.Uni-Bielefeld.DE> (Rainer Orth's message of "Fri, 12 Aug 2016 11:15:16 +0200")
Hi Ian,
>>> this patch broke i386-pc-solaris2.12 and sparc-sun-solaris2.12
>>> bootstrap, however: in both cases, the 64-bit build of os.lo fails like this:
>>>
>>> /vol/gcc/src/hg/trunk/local/libgo/go/os/dir.go:82:8: error: reference to undefined name 'libc_readdir_r'
>>> i := libc_readdir_r(file.dirinfo.dir, entryDirent, pr)
>>> ^
>>>
>>> Neither dir_largefile.go (which is correctly omitted, being 32-bit only)
>>> nor dir_regfile.go (which is needed here) is included in the
>>> compilation.
>>
>> Sorry, I don't know what I messed up in my testing. I committed the
>> appended patch, which should fix the problem.
>
> I had found a different one to the same effect, but running match.sh
> with yours looked right, too.
here's another issue found during wider testing: on Solaris 10 with
/bin/ksh as CONFIG_SHELL, the build aborts like this:
objcopy: 'bufio.o': No such file
Makefile:5072: recipe for target 'bufio.gox' failed
make[4]: *** [bufio.gox] Error 1
It turns out that no bufio.o is created indeed:
/vol/gcc/src/hg/trunk/local/libgo/../install-sh -c -d .; files=`echo | sed -e 's/[^ ]*\.gox//g' -e 's/[^ ]*\.dep//'`; /bin/ksh ./libtool --tag GO --mode=compile /var/gcc/regression/trunk/10-gcc/build/./gcc/gccgo -B/var/gcc/regression/trunk/10-gcc/build/./gcc/ -B/vol/gcc/i386-pc-solaris2.10/bin/ -B/vol/gcc/i386-pc-solaris2.10/lib/ -isystem /vol/gcc/i386-pc-solaris2.10/include -isystem /vol/gcc/i386-pc-solaris2.10/sys-include -minline-all-stringops -g -O2 -I . -c -fgo-pkgpath=`echo bufio.lo | sed -e 's/.lo$//' -e 's/-go$//'` -o bufio.lo $files
The list of input files, output from the likes of
/bin/ksh /vol/gcc/src/hg/trunk/local/libgo/match.sh --goarch=386 --goos=solaris --srcdir=/vol/gcc/src/hg/trunk/local/libgo/go/bufio --extrafiles=""
is empty. Running match.sh with /bin/ksh -x reveals
+ set -e
+ unset LANG
where the script aborts. It turns out that /bin/ksh errors out on an
unset of a variable that isn't set.
Maybe one could explicitly set LANG=C here, or use the `portable unset'
used in configure?
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2016-08-12 13:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 0:36 Ian Lance Taylor
2016-08-07 12:14 ` Andreas Schwab
2016-08-07 15:18 ` Matthias Klose
2016-08-07 22:33 ` Ian Lance Taylor
2016-09-04 16:24 ` Matthias Klose
2016-09-23 21:53 ` Ian Lance Taylor
2016-08-08 18:15 ` Lynn A. Boger
2016-08-08 18:26 ` Ian Lance Taylor
2016-08-08 19:07 ` Lynn A. Boger
2016-08-08 20:34 ` Ian Lance Taylor
2016-08-09 15:46 ` Lynn A. Boger
2016-08-11 15:16 ` Rainer Orth
2016-08-11 21:36 ` Ian Lance Taylor
2016-08-12 9:15 ` Rainer Orth
2016-08-12 13:56 ` Rainer Orth [this message]
2016-08-13 2:53 ` Ian Lance Taylor
2016-08-13 0:14 ` Ian Lance Taylor
2016-08-12 11:20 ` Andreas Krebbel
2016-08-13 0:23 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydda8gi3xbn.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=iant@golang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).