[v3] Ignore elfdump warnings in scripts/extract_symvers.pl

[v3] Ignore elfdump warnings in scripts/extract_symvers.pl

[Rainer Orth]

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

The libstdc++-v3 abi_check test is FAILing on Solaris 11 with gld.  It
turns out this happens because a elfdump warning (printed to stderr) is
mixed with regular elfdump output.  In the case at hand, elfdump warns

 .gnu.version_r: zero sh_entsize information, expected 0x1
 .gnu.version_d: zero sh_entsize information, expected 0x1

but obviously trying to parse warnings as regular output is doomed to
fail.  While it has been determined that those concrete warnings are
bogus and will be removed in the future, the general problem remains.
The following patch fixes this by just ignoring elfdump error output.

Bootstrapped without regressions on i386-pc-solaris2.1[01] and
sparc-sun-solaris2.1[01] (with as/ld, gas/gld) on both mainline and
gcc-5 branch.  Ok for mainline and gcc-5 branch?  I suppose the patch is
safe enough even at this point since it only affects a solaris specific
file.

	Rainer


2015-04-09  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* scripts/extract_symvers.pl: Ignore elfdump error output.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: sol2-v3-extract_symvers-elfdump.patch --]
[-- Type: text/x-patch, Size: 812 bytes --]

# HG changeset patch
# Parent 8093370756d009b628285d00fd7c4513d91fea92
Ignore elfdump warnings in scripts/extract_symvers.pl

diff --git a/libstdc++-v3/scripts/extract_symvers.pl b/libstdc++-v3/scripts/extract_symvers.pl
--- a/libstdc++-v3/scripts/extract_symvers.pl
+++ b/libstdc++-v3/scripts/extract_symvers.pl
@@ -82,7 +82,10 @@ while (<PVS>) {
 close PVS or die "pvs error";
 
 # Only look at .dynsym table, like readelf in extract_symvers.
-open ELFDUMP, "/usr/ccs/bin/elfdump -s -N .dynsym $lib |" or die $!;
+# Ignore error output to avoid getting confused by
+# .gnu.version_r: zero sh_entsize information, expected 0x1
+# warning with Solaris 11 elfdump on gld-produced shared objects.
+open ELFDUMP, "/usr/ccs/bin/elfdump -s -N .dynsym $lib 2>/dev/null |" or die $!;
 while (<ELFDUMP>) {
     chomp;
 

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]


-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: [v3] Ignore elfdump warnings in scripts/extract_symvers.pl

[Jonathan Wakely]

On 14 April 2015 at 13:59, Rainer Orth wrote:
> Bootstrapped without regressions on i386-pc-solaris2.1[01] and
> sparc-sun-solaris2.1[01] (with as/ld, gas/gld) on both mainline and
> gcc-5 branch.  Ok for mainline and gcc-5 branch?  I suppose the patch is
> safe enough even at this point since it only affects a solaris specific
> file.

OK for trunk, I can't approve the branch.

Re: [v3] Ignore elfdump warnings in scripts/extract_symvers.pl

[Richard Biener]

On Tue, 14 Apr 2015, Jonathan Wakely wrote:

> On 14 April 2015 at 13:59, Rainer Orth wrote:
> > Bootstrapped without regressions on i386-pc-solaris2.1[01] and
> > sparc-sun-solaris2.1[01] (with as/ld, gas/gld) on both mainline and
> > gcc-5 branch.  Ok for mainline and gcc-5 branch?  I suppose the patch is
> > safe enough even at this point since it only affects a solaris specific
> > file.
> 
> OK for trunk, I can't approve the branch.

Ok for the branch.

Thanks,
Richard.