public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Unreviewed libgcc build patch
@ 2011-06-20 11:09 Rainer Orth
  2011-06-21 15:08 ` Paolo Bonzini
  0 siblings, 1 reply; 3+ messages in thread
From: Rainer Orth @ 2011-06-20 11:09 UTC (permalink / raw)
  To: gcc-patches; +Cc: Paolo Bonzini, Ralf Wildenhues, Ian Lance Taylor

The following patch

	[build, libgcc] Correctly apply c_flags in shared-object.mk
        http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01055.html

has remained unreviewed for a week.  It needs a libgcc or build
maintainer to review.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Unreviewed libgcc build patch
  2011-06-20 11:09 Unreviewed libgcc build patch Rainer Orth
@ 2011-06-21 15:08 ` Paolo Bonzini
  2011-06-21 15:13   ` Rainer Orth
  0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2011-06-21 15:08 UTC (permalink / raw)
  To: Rainer Orth, gcc-patches, Ralf Wildenhues, Ian Lance Taylor

Ok without the commented info evaluation, and with the per-target
macro renamed to c_flags-$<.

Thanks,

Paolo


2011/6/20, Rainer Orth <ro@cebitec.uni-bielefeld.de>:
> The following patch
>
> 	[build, libgcc] Correctly apply c_flags in shared-object.mk
>         http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01055.html
>
> has remained unreviewed for a week.  It needs a libgcc or build
> maintainer to review.
>
> Thanks.
>         Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>

-- 
Inviato dal mio dispositivo mobile

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Unreviewed libgcc build patch
  2011-06-21 15:08 ` Paolo Bonzini
@ 2011-06-21 15:13   ` Rainer Orth
  0 siblings, 0 replies; 3+ messages in thread
From: Rainer Orth @ 2011-06-21 15:13 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: gcc-patches, Ralf Wildenhues, Ian Lance Taylor

Paolo Bonzini <bonzini@gnu.org> writes:

> Ok without the commented info evaluation, and with the per-target
> macro renamed to c_flags-$<.

Here's what I've installed after rebuilding libgcc and verifying that
-fexceptions still isn't applied to enable-execute-stack.c.

Thanks.
        Rainer


2011-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* shared-object.mk (c_flags-$o): Save c_flags.
	($(base)$(objext)): Use it.
	($(base)_s$(objext)): Likewise.

Index: libgcc/shared-object.mk
===================================================================
--- libgcc/shared-object.mk	(revision 175260)
+++ libgcc/shared-object.mk	(working copy)
@@ -6,13 +6,15 @@
 
 base := $(basename $(notdir $o))
 
+c_flags-$o := $(c_flags)
+
 ifeq ($(suffix $o),.c)
 
 $(base)$(objext): $o
-	$(gcc_compile) $(c_flags) -c $< $(vis_hide)
+	$(gcc_compile) $(c_flags-$<) -c $< $(vis_hide)
 
 $(base)_s$(objext): $o
-	$(gcc_s_compile) $(c_flags) -c $<
+	$(gcc_s_compile) $(c_flags-$<) -c $<
 
 else
 
-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-06-21 14:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-20 11:09 Unreviewed libgcc build patch Rainer Orth
2011-06-21 15:08 ` Paolo Bonzini
2011-06-21 15:13   ` Rainer Orth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).