From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32138 invoked by alias); 3 Jun 2011 19:38:52 -0000 Received: (qmail 32129 invoked by uid 22791); 3 Jun 2011 19:38:51 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Jun 2011 19:38:36 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 279A8FBC; Fri, 3 Jun 2011 21:38:35 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8lZia8KI9Bs8; Fri, 3 Jun 2011 21:38:32 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 723F8FBB; Fri, 3 Jun 2011 21:38:32 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p53JcVNl002307; Fri, 3 Jun 2011 21:38:31 +0200 (MEST) From: Rainer Orth To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Subject: Re: [testsuite] Run TLS torture tests with -fpic etc. References: Date: Fri, 03 Jun 2011 19:38:00 -0000 In-Reply-To: (Rainer Orth's message of "Mon, 30 May 2011 17:21:10 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00277.txt.bz2 Rainer Orth writes: > As suggested by Joseph, the gcc.dg/torture/tls tests should be run with > -fpic/-fPIC and -fpie/-fPIE if supported. > > The patch below implements part of this. Unlike > gcc.dg/torture/stackalign/stackalign.exp, I'm using the code below to > add -fpic etc. to the torture options so it shows up in gcc.sum. > > Unfortunately, I have no idea how to properly test if -fpie/-fPIE is > supported. Jakub, do you have a suggestion? Such a test could (and Jakub, any suggestion how to properly test for -fpie/-fPIE support? Otherwise, I'll remove that part of the patch for now and just commit the -fpic/-fPIC one. > probably should) be used in the few tests we currently have for -fpie: > > gcc.dg/tls/pie-1.c, gcc.dg/pie-link.c, gcc.target/i386/pr39013-[12].c > > Bootstrapped without regression on i386-pc-solaris2.11. > > Will install on mainline unless someone objects once the -fpie test has > been fixed. > > Rainer > > > 2011-05-28 Rainer Orth > > * lib/target-supports.exp (check_effective_target_fpie): New proc. > * gcc.dg/torture/tls/tls.exp: Load torture-options.exp. > Run tests with -fpic/-fPIC, -fpie/-fPIE if supported. > > diff --git a/gcc/testsuite/gcc.dg/torture/tls/tls.exp b/gcc/testsuite/gcc.dg/torture/tls/tls.exp > --- a/gcc/testsuite/gcc.dg/torture/tls/tls.exp > +++ b/gcc/testsuite/gcc.dg/torture/tls/tls.exp > @@ -1,4 +1,4 @@ > -# Copyright (C) 2010 Free Software Foundation, Inc. > +# Copyright (C) 2010, 2011 Free Software Foundation, Inc. > > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > @@ -18,6 +18,7 @@ > > # Load support procs. > load_lib gcc-dg.exp > +load_lib torture-options.exp > > # If a testcase doesn't have special options, use these. > global DEFAULT_CFLAGS > @@ -25,12 +26,32 @@ if ![info exists DEFAULT_CFLAGS] then { > set DEFAULT_CFLAGS " -ansi -pedantic-errors" > } > > +global DG_TORTURE_OPTIONS LTO_TORTURE_OPTIONS > +set TLS_TORTURE_OPTIONS $DG_TORTURE_OPTIONS > +if { [check_effective_target_fpic] } then { > + foreach pic {fpic fPIC} { > + foreach option $DG_TORTURE_OPTIONS { > + lappend TLS_TORTURE_OPTIONS "$option -$pic" > + } > + } > +} > +if { [check_effective_target_fpie] } then { > + foreach pie {fpie fPIE} { > + foreach option $DG_TORTURE_OPTIONS { > + lappend TLS_TORTURE_OPTIONS "$option -$pie" > + } > + } > +} > + > # Initialize `dg'. > dg-init > +torture-init > +set-torture-options $TLS_TORTURE_OPTIONS {{}} $LTO_TORTURE_OPTIONS > > # Main loop. > gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] \ > $DEFAULT_CFLAGS > > # All done. > +torture-finish > dg-finish > diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp > --- a/gcc/testsuite/lib/target-supports.exp > +++ b/gcc/testsuite/lib/target-supports.exp > @@ -788,6 +788,18 @@ proc check_effective_target_fpic { } { > return 0 > } > > +# Return 1 if -fpie and -fPIE are supported, as in no warnings or errors > +# emitted, 0 otherwise. > + > +proc check_effective_target_fpie { } { > + if [check_no_compiler_messages fpie executable { > + int main (void) { return 0; } > + } "-fpie"] { > + return 1 > + } > + return 0 > +} > + > # Return true if the target supports -mpaired-single (as used on MIPS). > > proc check_effective_target_mpaired_single { } { -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University