From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 00F083858D35 for ; Mon, 15 Apr 2024 08:56:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00F083858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00F083858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713171403; cv=none; b=q/1qqI16LaCkBGawMq97A/pkD0xEIPwBpvd+9WRKYjNTuAbH5ByQGyylHUKZ/oUBKcHvqTryF9+3abuVwu3oFqTAmpKJ9HAVtZ79PxtNIhy/89ACPunxi9xGC41f79clnooH2dqNaboGHFSanamBe1Dpc8w2fLhDPe7y5oILso4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713171403; c=relaxed/simple; bh=moQFttpq+lrUaV1aCtBM7LIQoPQVlnzlU/ioQc9kXD8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qgVKLY6omCHs1JTNz3OQIEw3C6X87xzIP++9vQqSAyQQe3Nj70dtpN4ldY8Bh/Bv6rVsjqjQKtNvHbQqT75LwRfizHuFkoxb6yr3wV1v451YMUf703zM4iRUdj588dUAXAmoSPGFB+aTltzgghpRHuenPOWBHchWyuoduCW3Is8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id F1BABCB5F1; Mon, 15 Apr 2024 10:56:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-transfer-encoding :content-type:content-type:mime-version:user-agent:message-id :in-reply-to:date:date:references:subject:subject:from:from :received:received; s=20200306; t=1713171399; bh=moQFttpq+lrUaV1 aCtBM7LIQoPQVlnzlU/ioQc9kXD8=; b=I7I+UmuGia5DL8DaQSvbloB0sxHJ7Kj gsekndscT6z/+aM2PD99uD21qCRx8qcVxYmu4euz2B+oQFrhSfbmoZhAfCDMGnaf bxGMfVfZXmHy4HFY9LT7muhuVgkiItHxXaIHQuJ1rmVSKWFkSg3vav71vHrfbXq9 OQxBCdLO7YQ5SR2rUV7w2IojI3yX5tvYx6NQVvhlDk+RUqbLRVk1L7UHjaoPjnxo g/1s+YWP0ei+Ct/z2mBJB4zZDMfVb562TYnGBogNFt0NdWr8mSc3zoqHKU3Av3JH pJ2c9kiJRvATtWq2b1XAWJLxrAlkV4mhJTKnYiIgH/5lkpnEnxo+Dzg== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ac4WsLMUMsSd; Mon, 15 Apr 2024 10:56:39 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50855b96.dip0.t-ipconnect.de [80.133.91.150]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 0A922CB73F; Mon, 15 Apr 2024 10:56:39 +0200 (CEST) From: Rainer Orth To: =?utf-8?Q?J=C3=B8rgen?= Kvalsvik Cc: gcc-patches@gcc.gnu.org, hjl.tools@gmail.com, rguenther@suse.de, hubicka@ucw.cz Subject: Re: [PATCH 1/2] Remove unecessary and broken MC/DC compile test References: <20240405195831.2728853-1-j@lambda.is> <20240405195831.2728853-2-j@lambda.is> Date: Mon, 15 Apr 2024 10:56:38 +0200 In-Reply-To: <20240405195831.2728853-2-j@lambda.is> (=?utf-8?Q?=22J=C3=B8r?= =?utf-8?Q?gen?= Kvalsvik"'s message of "Fri, 5 Apr 2024 21:58:30 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3784.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi J=C3=B8rgen, > The __sigsetjmp test was added as a regression test, which an early > iteration of the MC/DC support caused an internal compiler error, > triggered by a code path which did not make it through to the final > revision. Since this test really only worked on linux and does not > serve a purpose any more it can be removed. > > gcc/testsuite/ChangeLog: > > * gcc.misc-tests/gcov-19.c: Remove test. just a nit (and too late since it's already checked in): the ChangeLog entry should specify *which test* was removed. As is, it reads like the whole file has been removed. Something like * gcc.misc-tests/gcov-19.c (__sigsetjmp, mcdc021c): Remove. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University