From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Xi Ruoyao via Gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: doc: extend --{enable,disable}-libsanitizer description [PR 105614]
Date: Thu, 30 Jun 2022 13:54:18 +0200 [thread overview]
Message-ID: <yddbkuas6xh.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <c92b41f5883f997abc5dad5aee37c4a87edeb06d.camel@xry111.site> (Xi Ruoyao via Gcc-patches's message of "Thu, 30 Jun 2022 18:34:31 +0800")
Hi Xi,
> A documentation improvement with no code change. OK for trunk?
>
> -- >8 --
>
> We are receiving several reports that people are (mis)using
> --enable-libsanitizer option, which was not documented by GCC
> installation doc. It forces to build libsanitizer even for unsupported
> targets, causing build failure. Extend the --disable-libsanitizer
> description to also include --enable-libsanitizer, and warn about the
> possible consequences if it's enabled explicitly.
this behaviour isn't specific to libsanitizer at all: it probably
pertains to every target library using configure.tgt (libatomic,
libgomp, libitm, liboffloadmic, libphobos, libsanitizer, libvtv). I
think it should be documented in a more generic way.
> gcc/ChangeLog:
>
> PR sanitizer/105614
> * doc/install.texi: Document --enable-libsanitizer and possible
> consequences.
It's better to specific which part of install.texi is affected. In this
case, this would be
* doc/install.texi (Configuration, --disable-libsanitizer): ...
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
prev parent reply other threads:[~2022-06-30 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 10:34 Xi Ruoyao
2022-06-30 11:54 ` Rainer Orth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddbkuas6xh.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).