From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id C0344385840E for ; Fri, 4 Feb 2022 13:07:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C0344385840E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 57C4DACDD5; Fri, 4 Feb 2022 14:07:38 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gio0dFYzG51a; Fri, 4 Feb 2022 14:07:36 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508554ce.dip0.t-ipconnect.de [80.133.84.206]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 82D4AAD081; Fri, 4 Feb 2022 14:07:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1643980056; bh=sSWKmgqP42AG6sTQUVbJhE7coNNwNY4yDwNISbc9I7c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ibWSuZl/5RUnuXI9LXwdsL/7/6kZttTeylDPN7mIMVTqPKdT/9Z7kyj7jj//ijCa4 NnnrUtsmrWrO5v0rKKwWCqpxSp6Z51Aw9MHIdHQhWtHyAvToi4IvN9h01t6uYUssNG NobB5SHfwwY2d87Id5/vOJx/VJSpMNTvxbcT7iEW8lJoiYnECX3jo6mkiqYKrMpWo/ tdNw+SlJ8UMqKTGZFdymmLGyq7eR42suKlPnrzU55GH7V853NrRiHTUniQIkBUD6Kj Ntf6J8Jf6vJFmtcZ3b/Uyu9GYZim0sZIxHOrvwKkPjDtvuQh8fOhJGaS2sEWt170uE LswX6FFPkDaQA== From: Rainer Orth To: Martin =?utf-8?Q?Li=C5=A1ka?= Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] configure: add --disable-fix-includes References: <417eca08-e1ad-538e-c39a-388e20e2fcca@suse.cz> Date: Fri, 04 Feb 2022 14:07:35 +0100 In-Reply-To: <417eca08-e1ad-538e-c39a-388e20e2fcca@suse.cz> ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Fri, 4 Feb 2022 13:52:57 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3794.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 13:07:42 -0000 Hi Martin, > It seems to me that fixincludes is hardy unused feature for nowadays header > files and so I'm suggesting a developer option that can skip the fixing. please remember that there's a world beyond current-day Linux. > How is the feature used on other targets? There are still quite a number of fixes on e.g. Solaris or macOS. And people are still building gcc on older OS versions for one reason or another... > diff --git a/gcc/configure.ac b/gcc/configure.ac > index 1171c946e6e..6015e403aa9 100644 > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -842,6 +842,12 @@ gather_stats=`if test $enable_gather_detailed_mem_stats != no; then echo 1; else > AC_DEFINE_UNQUOTED(GATHER_STATISTICS, $gather_stats, > [Define to enable detailed memory allocation stats gathering.]) > > +AC_ARG_ENABLE(disable-fix-includes, > +[AS_HELP_STRING([--disable-fix-includes], The beast is called fixincludes, no '-' or '_'. > + [skip fixing of includes])], [], Better say 'running fixincludes' for example rather than being vague/obtuse. The new options requires documenting in install.texi. That said, I'm not sure this is really worth yet adding another option. And how are developers supposed to know if they can safely use it or not. Besides, have you actually run a regtest with that option? I'm asking because even on Ubuntu 20.04 fixincludes drops in it's own . You need to check that dropping that is actually safe. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University