From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 4335738930C7 for ; Thu, 17 Dec 2020 13:49:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4335738930C7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 14C1CAF8F; Thu, 17 Dec 2020 14:49:43 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lMaVy3XH5Ov2; Thu, 17 Dec 2020 14:49:42 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddb2f4.dip0.t-ipconnect.de [79.221.178.244]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 8BA1DA9FD; Thu, 17 Dec 2020 14:49:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1608212982; bh=+mA77BcRCbm7NJVklnGRQAj//NTvAl/U18h4uHTMvUU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=T/3Cyx8JXfVBY5rF6pgzWZcrtU+OrwfiQq+EnJo4ibBuouo5+llA6z1fpnb3+YuRA JVAaf1QKVvjhRmXMnCmxzaZvFIUf1RZnlb3lyIU4M7b4kLjYxgE1TfdX422iFNUoTc cyRq6NgtVHGSeiS0MBK7vofk8UuMb6Su65UwdnnKvrIjYL+FgfLuuKvZO3t3cYONqL qaTg8hpy55dP2xJBCQHvd/pdSC37ayWOiTPjmZk2RQWpCy/pWRKTee3jbQCnfrqEJr 8BdzbcwMsOeKrezUUBgs9V9Jqj8gZBryu7p/bYo1Dye6vwtL+GL0GjwYaAuV6YkwHk 0NcYM3SpoZhXQ== From: Rainer Orth To: Kyrylo Tkachov Cc: "gcc-patches\@gcc.gnu.org" , Richard Sandiford Subject: Re: [PATCH] rtl-ssa: Include memmodel.h before tm_p.h References: Date: Thu, 17 Dec 2020 14:49:41 +0100 In-Reply-To: (Kyrylo Tkachov's message of "Thu, 17 Dec 2020 13:41:21 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3790.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 13:49:45 -0000 Hi Kyryll, >> Fixed by moving the memmove.h include in rtl-ssa.h before tm_p.h. >>=20 >> Tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11 (both into stage >> 3 now, so the compilation error is gone). >>=20 >> Ok for master? > > AFAIK simple patches like this that fix build/bootstrap are viewed as > obvious and can be committed. > I hope I'm not wrong =F0=9F=98=8A I know, however I'm always unsure about the proper include order, thus asking for review. Thanks. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University