From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70516 invoked by alias); 19 May 2017 09:03:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70499 invoked by uid 89); 19 May 2017 09:03:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 May 2017 09:03:56 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 48A2169E; Fri, 19 May 2017 11:03:57 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dLIea9mb33O4; Fri, 19 May 2017 11:03:55 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 682BA69D; Fri, 19 May 2017 11:03:55 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id v4J93sMu014891; Fri, 19 May 2017 11:03:54 +0200 (MEST) From: Rainer Orth To: Daniel Santos Cc: Mike Stump , gcc-patches , Bernd Edlinger Subject: Re: [PATCH 0/2] [testsuite] PR80759 Fix test breakages on i386-pc-solaris2.* References: <3c867dc8-7d4a-ae82-c875-d03ff6d88776@pobox.com> Date: Fri, 19 May 2017 09:04:00 -0000 In-Reply-To: <3c867dc8-7d4a-ae82-c875-d03ff6d88776@pobox.com> (Daniel Santos's message of "Fri, 19 May 2017 01:32:48 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg01525.txt.bz2 Hi Daniel, > There are a few issues with my ms-sysv.exp tests: > > 1. Use of gas extensions in do_test.S cause breakages on Solaris, > 2. Parallelization breaks when no make -j flag is passed, > 3. Builds aren't adding TEST_ALWAYS_FLAGS, so log files filled with > color escape codes, and > 4. The "test unsupported" message is being spammed once for each -j > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80759 > > I've broken this apart into two patches because I don't know if you'll > agree with the first one. I fixed the make -j issue and moved the > parallelization code into a new gcc/target/lib/parallelize.exp in the first > patch and fixed all of the other issues in the second. I've removed all > usage of gas .struct in my assembly file, used hard-coded the offsets into > the code and added asserts to main.c to make sure they don't change. > > I've bootstrapped and retested on x86_64 Linux and have asked Rainer to > retest on Solaris. Presuming that succeeds, are you OK with this change? unfortunately, it still doesn't, as explained in the PR. The multilib support is still wrong/non-existant. > (I have SVN write privs now, so I can even commit it myself). Please always include ChangeLog entries with your patch submissions so one can easily see what you've change (cf. https://gcc.gnu.org/contribute.html). Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University