From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15627 invoked by alias); 27 Sep 2016 10:15:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15618 invoked by uid 89); 27 Sep 2016 10:15:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=preparation, prefixed, dwarf2out_init, sk:dwarf_s X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Sep 2016 10:15:32 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id CE440E9E; Tue, 27 Sep 2016 12:15:29 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1Q-fyUrJJi8K; Tue, 27 Sep 2016 12:15:28 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id F1FAEE9C; Tue, 27 Sep 2016 12:15:27 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id u8RAFQG0003042; Tue, 27 Sep 2016 12:15:26 +0200 (MEST) From: Rainer Orth To: Richard Biener Cc: gcc-patches@gcc.gnu.org, jason@redhat.com Subject: Re: [PATCH] Refactor section/label init for early LTO debug References: Date: Tue, 27 Sep 2016 10:23:00 -0000 In-Reply-To: (Richard Biener's message of "Wed, 21 Sep 2016 15:19:39 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg01918.txt.bz2 Hi Richard, > The following patch ports a refactoring of section/label in it from > the early LTO debug work to trunk. For early LTO debug we need to > be able to emit two sets of debug infos into two sets of different > sections - early LTO into .gnu.debuglto_ prefixed sections and > regular (early + late) debug for the FAT part of the object. > > Thus this preparation splits out the section and label generation > from dwarf2out_init moving the text section related stuff to > dwarf2out_assembly_start and the rest to a new function > init_sections_and_labels which is now called only before we start > outputting dwarf (in dwarf2out_finish). It also removes some > dwarf_split_debug_info checks from the macro section name defines > (in the end I'll have up to four variants - regular, regular LTO, > DWO, DWO LTO). > > And it removes an unused function. > > Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. I've > also bootstrapped with -O2 -g3 to exercise the .debug_macro path. > > Ok? > > Just noticed that DEBUG_STR_OFFSETS_SECTION needs similar massaging > for its dwarf_split_debug_info condition - will followup as obvious > if this one is approved. this patch introduced many pch assembly comparison failures on Solaris (both sparc and x86, 32 and 64-bit, /bin/as only), like FAIL: gcc.dg/pch/common-1.c -O3 -g assembly comparison FAIL: gcc.dg/pch/common-1.c -O0 -g assembly comparison gcc.log shows this diff: < .long .Letext0 > .long While the .Letext0 label is still in the assembly output, it isn't referenced inside .debug_line, as can be seen in the diff. Unlike the gas case, with as HAVE_AS_DWARF2_DEBUG_LINE isn't defined. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University