From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: "François Dumont" <frs.dumont@gmail.com>,
"Jonathan Wakely" <jwakely@redhat.com>,
libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] Move std::search into algobase.h
Date: Thu, 01 Jun 2023 13:52:17 +0200 [thread overview]
Message-ID: <yddfs7bo0we.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <CACb0b4=Z+jojRW4JQ_C2nvhe0uwKNf-Nm9q6qYFMTosDoGEQ8Q@mail.gmail.com> (Jonathan Wakely via Gcc-patches's message of "Wed, 31 May 2023 18:55:41 +0100")
Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> On Wed, 31 May 2023 at 18:39, François Dumont via Libstdc++ <
> libstdc++@gcc.gnu.org> wrote:
>
>> libstdc++: Reduce <functional> inclusion to <stl_algobase.h>
>>
>>
>> Move the std::search definition from stl_algo.h to stl_algobase.h and use
>> the later in <functional>.
>>
>> For consistency also move std::__parallel::search and associated helpers
>> from
>> <parallel/stl_algo.h> to <parallel/stl_algobase.h> so that
>> std::__parallel::search
>> is accessible along with std::search.
>>
>> libstdc++-v3/ChangeLog:
>>
>> * include/bits/stl_algo.h
>> (std::__search, std::search(_FwdIt1, _FwdIt1, _FwdIt2,
>> _FwdIt2, _BinPred)): Move...
>> * include/bits/stl_algobase.h: ...here.
>> * include/std/functional: Replace <stl_algo.h> include by
>> <stl_algobase.h>.
>> * include/parallel/algo.h (std::__parallel::search<_FIt1,
>> _FIt2, _BinaryPred>)
>> (std::__parallel::__search_switch<_FIt1, _FIt2,
>> _BinaryPred, _ItTag1, _ItTag2>):
>> Move...
>> * include/parallel/algobase.h: ...here.
>> * include/std/functional: Remove <bits/stl_algo.h> and
>> <parallel/algorithm>
>> includes. Include <bits/stl_algobase.h>.
>>
>> Tested under Linux x86_64.
>>
>> Ok to commit ?
>>
>
> OK
This seems to have caused
+FAIL: 17_intro/headers/c++2011/parallel_mode.cc (test for excess errors)
+FAIL: 17_intro/headers/c++2014/parallel_mode.cc (test for excess errors)
on i386-pc-solaris2.11:
Excess errors:
/var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++-v3/include/parallel/algobase.h:496: error: '__search_template' is not a member of '__gnu_parallel'; did you mean '__find_template'?
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2023-06-01 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 17:39 François Dumont
2023-05-31 17:55 ` Jonathan Wakely
2023-06-01 11:52 ` Rainer Orth [this message]
2023-06-01 12:05 ` Jonathan Wakely
2023-06-01 13:50 ` François Dumont
2023-06-01 20:36 ` François Dumont
2023-06-01 21:57 ` Jonathan Wakely
2023-06-02 7:33 ` François Dumont
2023-06-02 7:43 ` Jonathan Wakely
2023-06-02 9:47 ` François Dumont
2023-06-02 11:30 ` Jonathan Wakely
2023-06-02 12:34 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddfs7bo0we.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).