From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 58B143858C41; Thu, 1 Jun 2023 11:52:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58B143858C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 273C3AA3F4; Thu, 1 Jun 2023 13:52:18 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yoSgLQhJCkAJ; Thu, 1 Jun 2023 13:52:17 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50855504.dip0.t-ipconnect.de [80.133.85.4]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 99803AA3F3; Thu, 1 Jun 2023 13:52:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1685620337; bh=v2id6Ar6m8O0+krVAJq9KqpkSJVRMIDwHb3+XS6nFL0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bPjJyrgYc0XULEF3YM/4zPvSAsVRhH1dPuE4R98LTXN2+2u1E/V9zUAZSROf9yusu fxBBGxEfuPe2+lpTYMmZbqmg2RgUeQ1YSo/LdPEjfgtIQFHdARHIEmQFFMNU+7zVoB RtDOJN2tru7R34CpT1cCTqbjNMj/rpcVV4R5hCBmz/mkT10+SNr4D4XP6397pmnxVP HL3/NoU7GNJX32vCU2iS4gVpcvZT01PYSdb6zzajldLXFSMghPAFo3d0ArzlNdOGr7 c3w2Nc5Fza2TG+B8xuDmnfF7uZV2egeP/zTSOJ+QnaUt06wgzJ85DImKoYWeRgalz2 ByAGcXQtSRDsg== From: Rainer Orth To: Jonathan Wakely via Gcc-patches Cc: =?utf-8?Q?Fran=C3=A7ois?= Dumont , Jonathan Wakely , "libstdc++" Subject: Re: [PATCH] Move std::search into algobase.h References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> Date: Thu, 01 Jun 2023 13:52:17 +0200 In-Reply-To: (Jonathan Wakely via Gcc-patches's message of "Wed, 31 May 2023 18:55:41 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3785.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jonathan Wakely via Gcc-patches writes: > On Wed, 31 May 2023 at 18:39, Fran=C3=A7ois Dumont via Libstdc++ < > libstdc++@gcc.gnu.org> wrote: > >> libstdc++: Reduce inclusion to >> >> >> Move the std::search definition from stl_algo.h to stl_algobase.h and use >> the later in . >> >> For consistency also move std::__parallel::search and associated helpers >> from >> to so that >> std::__parallel::search >> is accessible along with std::search. >> >> libstdc++-v3/ChangeLog: >> >> * include/bits/stl_algo.h >> (std::__search, std::search(_FwdIt1, _FwdIt1, _FwdIt2, >> _FwdIt2, _BinPred)): Move... >> * include/bits/stl_algobase.h: ...here. >> * include/std/functional: Replace include by >> . >> * include/parallel/algo.h (std::__parallel::search<_FIt1, >> _FIt2, _BinaryPred>) >> (std::__parallel::__search_switch<_FIt1, _FIt2, >> _BinaryPred, _ItTag1, _ItTag2>): >> Move... >> * include/parallel/algobase.h: ...here. >> * include/std/functional: Remove and >> >> includes. Include . >> >> Tested under Linux x86_64. >> >> Ok to commit ? >> > > OK This seems to have caused +FAIL: 17_intro/headers/c++2011/parallel_mode.cc (test for excess errors) +FAIL: 17_intro/headers/c++2014/parallel_mode.cc (test for excess errors) on i386-pc-solaris2.11: Excess errors: /var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++= -v3/include/parallel/algobase.h:496: error: '__search_template' is not a me= mber of '__gnu_parallel'; did you mean '__find_template'? Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University