From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Kwok Cheung Yeung <kcy@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] openmp: Implement support for OMP_TARGET_OFFLOAD
Date: Tue, 20 Oct 2020 18:39:39 +0200 [thread overview]
Message-ID: <yddft68lulw.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <0f0a9bbc-2add-9d4d-b367-210a7f0063bd@codesourcery.com> (Tobias Burnus's message of "Tue, 20 Oct 2020 14:11:08 +0200")
Hi Tobias,
> On 10/19/20 8:21 PM, Jakub Jelinek via Gcc-patches wrote:
>
>> On Mon, Oct 19, 2020 at 06:57:49PM +0100, Kwok Cheung Yeung wrote:
>>> --- a/libgomp/target.c
>>> +++ b/libgomp/target.c
> ...
>> Otherwise LGTM.
>
> Unfortunately, the committed patch (r11-4121-g1bfc07d150790fae93184a79a7cce897655cb37b)
> causes build errors.
the patch also breaks bootstrap on both i386-pc-solaris2.11 and
sparc-sun-solaris2.11:
/vol/gcc/src/hg/master/local/libgomp/env.c: In function 'initialize_env':
/vol/gcc/src/hg/master/local/libgomp/env.c:414:16: error: 'new_offload' may be used uninitialized in this function [-Werror=maybe-uninitialized]
414 | *offload = new_offload;
| ~~~~~~~~~^~~~~~~~~~~~~
/vol/gcc/src/hg/master/local/libgomp/env.c:384:30: note: 'new_offload' was declared here
384 | enum gomp_target_offload_t new_offload;
| ^~~~~~~~~~~
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2020-10-20 16:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 20:32 Kwok Cheung Yeung
2020-10-15 10:50 ` Jakub Jelinek
2020-10-15 11:02 ` Jakub Jelinek
2020-10-19 17:57 ` Kwok Cheung Yeung
2020-10-19 18:21 ` Jakub Jelinek
2020-10-20 12:11 ` Tobias Burnus
2020-10-20 12:17 ` Tobias Burnus
2020-10-20 12:57 ` Jakub Jelinek
2020-10-20 21:28 ` Kwok Cheung Yeung
2020-10-20 16:39 ` Rainer Orth [this message]
2020-10-20 16:45 ` Jakub Jelinek
2020-10-22 10:44 ` Rainer Orth
2020-10-21 11:52 ` [PATCH] openmp: Change omp_get_initial_device () to match OpenMP 5.1 requirements Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddft68lulw.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kcy@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).