From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 50F9C3971C04 for ; Thu, 10 Sep 2020 10:41:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 50F9C3971C04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id F1271D01B; Thu, 10 Sep 2020 12:41:36 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DI4PHDz0EACf; Thu, 10 Sep 2020 12:41:36 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddbb33.dip0.t-ipconnect.de [79.221.187.51]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 1E438CEBB; Thu, 10 Sep 2020 12:41:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1599734496; bh=mbsGO0oVHd1/2Ydz7q5BtQX4VNSLhQxeiuhAWlXWEsI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Um/n7+t89aIuM3hWAVUa9SShMFj1LfpufOZQMxs47pc3G+G9Xg7O7NEuzQLyi8E7Z ZAYp5z27jE3LHCBrjbUU1sZ2XR/FtPPBmGTNCEMz1I4taRzf+oR7w+zxXUAg8SFob7 LSi8VigA8dYFFUNtg4aWJXUFP82G6mP+aIPT4osvXdzC1KT/HGKQ/MRyOsWdWc7uWK owNE5363mkF4zD58gbJ9q6RNPwbrFpUyQ5d3OVXPxOfZ9GqCxTSpqOH7atvOMXT6LA 9Sbj8ejMs7bL7ddDTlLDjJHkg/4KpvZ2jMlr09FjivsWCf30RjlqHm9UU+yh7gM6tK kKWDcjQR3W7dQ== From: Rainer Orth To: Iain Buclaw Cc: Iain Buclaw via Gcc-patches , "H.J. Lu" Subject: Re: [PATCH] libphobos: libdruntime doesn't support shadow stack (PR95680) References: <20200907213540.1881766-1-ibuclaw@gdcproject.org> <1599560137.uqp3ab0rt4.astroid@galago.none> <1599672058.46w0udrsg3.astroid@galago.none> Date: Thu, 10 Sep 2020 12:41:34 +0200 In-Reply-To: <1599672058.46w0udrsg3.astroid@galago.none> (Iain Buclaw's message of "Thu, 10 Sep 2020 00:57:22 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3790.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2020 10:41:39 -0000 Hi Iain, >> this patch broke Solaris/x86 bootstrap: >> >> /vol/gcc/src/hg/master/local/libphobos/libdruntime/core/thread.d:3595:23: >> error: version AsmExternal defined after use >> 3595 | version = AsmExternal; >> | ^ >> /vol/gcc/src/hg/master/local/libphobos/libdruntime/core/thread.d:3603:27: >> error: version AsmX86_Posix defined after use >> 3603 | version = AsmX86_Posix; >> | ^ >> >> and similarly for the 64-bit version. libdruntime/gcc/config.d has >> >> // Whether libphobos been configured with --enable-cet. >> enum GNU_Enable_CET = false; >> >> Rainer >> > > Looks like I can only use version conditions, or static if conditions. > Not both at the same time. Found a related bug in upstream dmd > https://issues.dlang.org/show_bug.cgi?id=7386 > > Fixing the front-end here will not be possible without some pervasive > changes in how symbol resolving is handled. Which is a shame. > > I'm just testing passing -fversion=CET during compilation. I've just tested it no i386-pc-solaris2.11: worked fine. Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University