* Top-level patch committed: Add check-gotools to check-go
@ 2017-06-14 19:36 Ian Lance Taylor
2017-06-15 21:01 ` Rainer Orth
0 siblings, 1 reply; 3+ messages in thread
From: Ian Lance Taylor @ 2017-06-14 19:36 UTC (permalink / raw)
To: gcc-patches, gofrontend-dev
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
I've committed this patch to the top level Makefile.def so that `make
check-go` will run `make check-gotools`. Bootstrapped and ran Go
testsuite on x86_64-pc-linux-gnu. Committed to mainline.
This patch may cause new test failures on other systems. Please let
me know about them. I don't anticipate anything in particular, but,
who knows.
Ian
2017-06-14 Ian Lance Taylor <iant@golang.org>
* Makefile.def: Add check-gotools to go check targets.
* Makefile.in: Rebuild.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 625 bytes --]
Index: Makefile.def
===================================================================
--- Makefile.def (revision 249171)
+++ Makefile.def (working copy)
@@ -601,7 +601,8 @@ languages = { language=objc; gcc-check-t
lib-check-target=check-target-libobjc; };
languages = { language=obj-c++; gcc-check-target=check-obj-c++; };
languages = { language=go; gcc-check-target=check-go;
- lib-check-target=check-target-libgo; };
+ lib-check-target=check-target-libgo;
+ lib-check-target=check-gotools; };
languages = { language=brig; gcc-check-target=check-brig;
lib-check-target=check-target-libhsail-rt; };
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Top-level patch committed: Add check-gotools to check-go
2017-06-14 19:36 Top-level patch committed: Add check-gotools to check-go Ian Lance Taylor
@ 2017-06-15 21:01 ` Rainer Orth
2017-06-16 0:12 ` Ian Lance Taylor
0 siblings, 1 reply; 3+ messages in thread
From: Rainer Orth @ 2017-06-15 21:01 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: gcc-patches, gofrontend-dev
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
Hi Ian,
> I've committed this patch to the top level Makefile.def so that `make
> check-go` will run `make check-gotools`. Bootstrapped and ran Go
> testsuite on x86_64-pc-linux-gnu. Committed to mainline.
>
> This patch may cause new test failures on other systems. Please let
> me know about them. I don't anticipate anything in particular, but,
> who knows.
the gotools test results came up empty on *-*-solaris2.12 with /bin/ksh.
In the make check-gotools output I found
(cd check-go-dir/src/cmd/go && /var/gcc/regression/trunk/12-gcc/build/gotools/go test -test.short -test.v) >& cmd_go-testlog || true
/bin/ksh: line 3: cmd_go-testlog: bad file unit number
If one uses the portable form of I/O redirection here, the test works on
Solaris, too.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
2017-06-15 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* Makefile.am (check-go-tool): Don't use >& for I/O redirection.
* Makefile.in: Regenerate.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gotools-ioredir.patch --]
[-- Type: text/x-patch, Size: 727 bytes --]
# HG changeset patch
# Parent 88b687cecf78f7c39cd989fc9c4906b2c71a549b
Don't use >& for I/O redirection
diff --git a/gotools/Makefile.am b/gotools/Makefile.am
--- a/gotools/Makefile.am
+++ b/gotools/Makefile.am
@@ -180,7 +180,7 @@ check-go-tool: go$(EXEEXT) check-head ch
$(CHECK_ENV) \
GOPATH=`cd check-go-dir && $(PWD_COMMAND)`; \
export GOPATH; \
- (cd check-go-dir/src/cmd/go && $(abs_builddir)/go$(EXEEXT) test -test.short -test.v) >& cmd_go-testlog || true
+ (cd check-go-dir/src/cmd/go && $(abs_builddir)/go$(EXEEXT) test -test.short -test.v) > cmd_go-testlog 2>&1 || true
grep '^--- ' cmd_go-testlog | sed -e 's/^--- \(.*\) ([^)]*)$$/\1/'
# The check targets runs the tests and assembles the output files.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Top-level patch committed: Add check-gotools to check-go
2017-06-15 21:01 ` Rainer Orth
@ 2017-06-16 0:12 ` Ian Lance Taylor
0 siblings, 0 replies; 3+ messages in thread
From: Ian Lance Taylor @ 2017-06-16 0:12 UTC (permalink / raw)
To: Rainer Orth; +Cc: gcc-patches, gofrontend-dev
On Thu, Jun 15, 2017 at 2:00 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
>
>> I've committed this patch to the top level Makefile.def so that `make
>> check-go` will run `make check-gotools`. Bootstrapped and ran Go
>> testsuite on x86_64-pc-linux-gnu. Committed to mainline.
>>
>> This patch may cause new test failures on other systems. Please let
>> me know about them. I don't anticipate anything in particular, but,
>> who knows.
>
> the gotools test results came up empty on *-*-solaris2.12 with /bin/ksh.
> In the make check-gotools output I found
>
> (cd check-go-dir/src/cmd/go && /var/gcc/regression/trunk/12-gcc/build/gotools/go test -test.short -test.v) >& cmd_go-testlog || true
> /bin/ksh: line 3: cmd_go-testlog: bad file unit number
>
> If one uses the portable form of I/O redirection here, the test works on
> Solaris, too.
>
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2017-06-15 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> * Makefile.am (check-go-tool): Don't use >& for I/O redirection.
> * Makefile.in: Regenerate.
Whoops.
This is OK. You can go ahead and commit--unlike the go/gofrontend and
libgo directories, this directory lives entirely in the GCC tree.
Thanks.
Ian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-16 0:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-14 19:36 Top-level patch committed: Add check-gotools to check-go Ian Lance Taylor
2017-06-15 21:01 ` Rainer Orth
2017-06-16 0:12 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).