From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115284 invoked by alias); 15 Jun 2017 21:01:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 114975 invoked by uid 89); 15 Jun 2017 21:00:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-20.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Jun 2017 21:00:46 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id D8C71163; Thu, 15 Jun 2017 23:00:46 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7mJLpM8DRJ-6; Thu, 15 Jun 2017 23:00:44 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p5DCE05A3.dip0.t-ipconnect.de [93.206.5.163]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id A5C5F162; Thu, 15 Jun 2017 23:00:44 +0200 (CEST) From: Rainer Orth To: Ian Lance Taylor Cc: gcc-patches , "gofrontend-dev\@googlegroups.com" Subject: Re: Top-level patch committed: Add check-gotools to check-go References: Date: Thu, 15 Jun 2017 21:01:00 -0000 In-Reply-To: (Ian Lance Taylor's message of "Wed, 14 Jun 2017 12:36:48 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01146.txt.bz2 --=-=-= Content-Type: text/plain Content-length: 1063 Hi Ian, > I've committed this patch to the top level Makefile.def so that `make > check-go` will run `make check-gotools`. Bootstrapped and ran Go > testsuite on x86_64-pc-linux-gnu. Committed to mainline. > > This patch may cause new test failures on other systems. Please let > me know about them. I don't anticipate anything in particular, but, > who knows. the gotools test results came up empty on *-*-solaris2.12 with /bin/ksh. In the make check-gotools output I found (cd check-go-dir/src/cmd/go && /var/gcc/regression/trunk/12-gcc/build/gotools/go test -test.short -test.v) >& cmd_go-testlog || true /bin/ksh: line 3: cmd_go-testlog: bad file unit number If one uses the portable form of I/O redirection here, the test works on Solaris, too. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University 2017-06-15 Rainer Orth * Makefile.am (check-go-tool): Don't use >& for I/O redirection. * Makefile.in: Regenerate. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=gotools-ioredir.patch Content-length: 727 # HG changeset patch # Parent 88b687cecf78f7c39cd989fc9c4906b2c71a549b Don't use >& for I/O redirection diff --git a/gotools/Makefile.am b/gotools/Makefile.am --- a/gotools/Makefile.am +++ b/gotools/Makefile.am @@ -180,7 +180,7 @@ check-go-tool: go$(EXEEXT) check-head ch $(CHECK_ENV) \ GOPATH=`cd check-go-dir && $(PWD_COMMAND)`; \ export GOPATH; \ - (cd check-go-dir/src/cmd/go && $(abs_builddir)/go$(EXEEXT) test -test.short -test.v) >& cmd_go-testlog || true + (cd check-go-dir/src/cmd/go && $(abs_builddir)/go$(EXEEXT) test -test.short -test.v) > cmd_go-testlog 2>&1 || true grep '^--- ' cmd_go-testlog | sed -e 's/^--- \(.*\) ([^)]*)$$/\1/' # The check targets runs the tests and assembles the output files. --=-=-=--