From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19229 invoked by alias); 6 Dec 2019 17:20:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19221 invoked by uid 89); 6 Dec 2019 17:20:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2 autolearn=ham version=3.3.1 spammy=HTo:D*ubuntu.com, weren't, werent, H*f:sk:70b9c68 X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Dec 2019 17:20:34 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 10BD4E44; Fri, 6 Dec 2019 18:20:32 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id c738kzmoAjRM; Fri, 6 Dec 2019 18:20:30 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p5085478D.dip0.t-ipconnect.de [80.133.71.141]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id D2771E43; Fri, 6 Dec 2019 18:20:29 +0100 (CET) From: Rainer Orth To: Matthias Klose Cc: Ian Lance Taylor , gcc-patches , gofrontend-dev Subject: Re: libgo patch committed: Always mark assembly file as non-executable stack References: <70b9c686-56ab-62fc-8d18-951ed1e3ba5f@ubuntu.com> Date: Fri, 06 Dec 2019 17:20:00 -0000 In-Reply-To: <70b9c686-56ab-62fc-8d18-951ed1e3ba5f@ubuntu.com> (Matthias Klose's message of "Fri, 6 Dec 2019 17:18:29 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00438.txt.bz2 Hi Matthias, > On 06.12.19 12:28, Rainer Orth wrote: >> I Ian, >> >>> This libgo patch arranges for go-context.S to always be marked as >>> using a non-executable stack. This is not required for all targets, >>> but should do little harm. Bootstrapped on x86_64-pc-linux-gnu. >>> Committed to mainline. >> >> unfortunately, it does, breaking bootstrap on Solaris/SPARC and x86 with >> the native assembler: >> >> * Solaris/SPARC with as: >> >> /usr/ccs/bin/as: "/var/tmp//ccSl12Nb.s", line 7: error: invalid character >> (0x40) >> /usr/ccs/bin/as: "/var/tmp//ccSl12Nb.s", line 7: error: quoted-string >> operand required >> /usr/ccs/bin/as: "/var/tmp//ccSl12Nb.s", line 7: error: statement syntax >> make[4]: *** [Makefile:1433: runtime/go-context.lo] Error 1 >> >> * Solaris/x86 with as: >> >> Assembler: >> "/vol/gcc/src/hg/trunk/local/libgo/runtime/go-context.S", line 74 >> : Syntax error >> Near line: " .section .note.GNU-stack,"",@progbits" >> make[4]: *** [Makefile:1433: runtime/go-context.lo] Error 1 > > also on arm-linux-gnueabi*. Patch in PR go/92820 that won't help: for one, those .note.GNU-stack sections are useless on Solaris. Even if this weren't the case, the syntax is still wrong: Solaris/SPARC as needs .section ".note.GNU-stack",,#progbits while Solaris/x86 as doesn't allow for '-' in section names (and there's no quoting mechanism IIRC). Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University