From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Jeff Law <law@redhat.com>
Cc: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
gcc-patches@gcc.gnu.org, Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v3] add support for --disable-gcov
Date: Wed, 27 Jun 2018 19:23:00 -0000 [thread overview]
Message-ID: <yddh8loavam.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <5d11f24b-6598-e160-5864-bacc8d8310bd@redhat.com> (Jeff Law's message of "Tue, 12 Jun 2018 15:18:15 -0600")
[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]
Hi Jeff,
>> So add an option for disabling build and install of libgcov and the
>> related host tools.
>>
>> 2018-06-10 Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>>
>> gcc/
>> * configure.ac: Add --disable-gcov option.
>> * configure: Regenerate.
>> * Makefile.in: Honour @enable_gcov@.
>> * doc/install.texi: Document --disable-gcov.
>>
>> libgcc/
>> * configure.ac: Add --disable-gcov option.
>> * configure: Regenerate.
>> * Makefile.in: Honour @enable_gcov@.
> OK. Presumably you're going through the process to get write access.
> Once that's wrapped up you can install this patch.
this patch badly broke all -fprofile-generate/-fprofile-use tests in the
default case like this:
UNRESOLVED: g++.dg/bprob/g++-bprob-1.C compilation, -O0 -fbranch-probabilities
FAIL: g++.dg/bprob/g++-bprob-1.C compilation, -O0 -fprofile-arcs
ld: fatal: library -lgcov: not found
collect2: error: ld returned 1 exit status
compiler exited with status 1
FAIL: g++.dg/bprob/g++-bprob-1.C compilation, -g -fprofile-arcs
libgcov.a is not copied over from libgcc to gcc due to a typo in
libgcc/Makefile.in. Fixed as follows; will install as obvious once
bootstrap has finished.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
2018-06-27 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* Makefile.in (install_leaf): Use enable_gcov instead of
enable_libgcov.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: libgcc-enable_gcov.patch --]
[-- Type: text/x-patch, Size: 613 bytes --]
# HG changeset patch
# Parent 5c87d0c29765b05d7da38622b0c67a4931fe47ce
Fix typo in Makefile.in
diff --git a/libgcc/Makefile.in b/libgcc/Makefile.in
--- a/libgcc/Makefile.in
+++ b/libgcc/Makefile.in
@@ -1168,7 +1168,7 @@ install-leaf: $(install-shared) $(instal
$(INSTALL_DATA) libgcc.a $(DESTDIR)$(inst_libdir)/
chmod 644 $(DESTDIR)$(inst_libdir)/libgcc.a
$(RANLIB) $(DESTDIR)$(inst_libdir)/libgcc.a
-ifeq ($(enable_libgcov),yes)
+ifeq ($(enable_gcov),yes)
$(INSTALL_DATA) libgcov.a $(DESTDIR)$(inst_libdir)/
chmod 644 $(DESTDIR)$(inst_libdir)/libgcov.a
$(RANLIB) $(DESTDIR)$(inst_libdir)/libgcov.a
next prev parent reply other threads:[~2018-06-27 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 13:06 [PATCH] libgcc: Add support for --disable-libgcov Rasmus Villemoes
2018-05-25 16:40 ` Joseph Myers
2018-05-25 21:35 ` [PATCH v2] " Rasmus Villemoes
2018-06-01 12:11 ` Rasmus Villemoes
2018-06-11 7:26 ` [PATCH v3] add support for --disable-gcov Rasmus Villemoes
2018-06-12 21:18 ` Jeff Law
2018-06-27 19:23 ` Rainer Orth [this message]
2018-06-27 21:01 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddh8loavam.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
--cc=rasmus.villemoes@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).