From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8815 invoked by alias); 21 Nov 2016 09:52:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8540 invoked by uid 89); 21 Nov 2016 09:52:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Nov 2016 09:52:41 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 7525C3B2; Mon, 21 Nov 2016 10:52:39 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id srOmhn0SM4zN; Mon, 21 Nov 2016 10:52:07 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 8E01F3AF; Mon, 21 Nov 2016 10:52:07 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id uAL9q7x9015857; Mon, 21 Nov 2016 10:52:07 +0100 (MET) From: Rainer Orth To: Mike Stump Cc: Bruce Korb , GCC Patches Subject: Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267) References: <5D0F34A7-12A8-4DEC-915A-4BE37CFD76A1@comcast.net> <338ADAEA-837C-4935-9222-DDB94363D3F2@comcast.net> Date: Mon, 21 Nov 2016 09:52:00 -0000 In-Reply-To: <338ADAEA-837C-4935-9222-DDB94363D3F2@comcast.net> (Mike Stump's message of "Fri, 18 Nov 2016 09:42:25 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg02092.txt.bz2 Hi Mike, > On Nov 18, 2016, at 2:45 AM, Rainer Orth wrote: >> So the current suggestion is to combine my fixincludes patch and Jack's >> patch to disable use if !__BLOCKS__. > >> I guess this is ok for mainline now to restore bootstrap? > > I think we are down to everyone likes this, Ok. The big question is, does > this need a back port? while they are not necessary to fix the libsanitizer bootstrap failure, they fix genuine header problems, so I think they're desirable. My plan has been to look into the problems discovered in 10.10 and 10.11 headers while developing this one, get them into mainline as time permits and backport the whole bunch afterwards. > If you fix includes virtual members or data members of C/C++ classes, just > be careful disappearing content as that can change the layout of the > structure or class. Understood. So far, the fixes have just removed attributes not supported by GCC, or types using such extensions and function declarations using them. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University