* [testsuite, i386] Avoid finite in gcc.target/i386/avx512dq-vfpclasspd-2.c etc.
@ 2015-04-08 13:27 Rainer Orth
2015-04-13 18:31 ` Kirill Yukhin
0 siblings, 1 reply; 6+ messages in thread
From: Rainer Orth @ 2015-04-08 13:27 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
Some AVX512DQ tests are failing on Solaris/x86 with gas:
FAIL: gcc.target/i386/avx512dq-vfpclasspd-2.c (test for excess errors)
FAIL: gcc.target/i386/avx512dq-vfpclassps-2.c (test for excess errors)
FAIL: gcc.target/i386/avx512vl-vfpclasspd-2.c (test for excess errors)
FAIL: gcc.target/i386/avx512vl-vfpclassps-2.c (test for excess errors)
FAIL: gcc.target/i386/avx512dq-vfpclasspd-2.c (test for excess errors)
Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.target/i386/avx512dq-vfpclasspd-2.c:24:20: warning: implicit declaration of function 'finite' [-Wimplicit-function-declaration]
finite() is non-standard and requires <ieeefp.h> on Solaris. Instead of
this, I believe it's simplest to just use __builtin_finite instead.
The following patch does just that. Tested with the appropriate runtest
invocation on i386-pc-solaris2.11 and x86_64-unknown-linux-gnu.
Ok for mainline?
Rainer
2015-04-08 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* gcc.target/i386/avx512dq-vfpclasspd-2.c (check_fp_class_dp): Use
__builtin_finite instead of finite.
* gcc.target/i386/avx512dq-vfpclassps-2.c (check_fp_class_sp):
Likewise.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: solx86-testsuite-avx512-finite.patch --]
[-- Type: text/x-patch, Size: 1373 bytes --]
# HG changeset patch
# Parent 4a9cc7114f8129eb1eda0f314ca2ae48494b48be
Avoid finite in gcc.target/i386/avx512dq-vfpclasspd-2.c etc.
diff --git a/gcc/testsuite/gcc.target/i386/avx512dq-vfpclasspd-2.c b/gcc/testsuite/gcc.target/i386/avx512dq-vfpclasspd-2.c
--- a/gcc/testsuite/gcc.target/i386/avx512dq-vfpclasspd-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512dq-vfpclasspd-2.c
@@ -21,7 +21,7 @@ int check_fp_class_dp (double src, int i
int PInf_res = (isinf (src) == 1);
int NInf_res = (isinf (src) == -1);
int Denorm_res = (fpclassify (src) == FP_SUBNORMAL);
- int FinNeg_res = finite (src) && (src < 0);
+ int FinNeg_res = __builtin_finite (src) && (src < 0);
int result = (((imm & 1) && qNaN_res)
|| (((imm >> 1) & 1) && Pzero_res)
diff --git a/gcc/testsuite/gcc.target/i386/avx512dq-vfpclassps-2.c b/gcc/testsuite/gcc.target/i386/avx512dq-vfpclassps-2.c
--- a/gcc/testsuite/gcc.target/i386/avx512dq-vfpclassps-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512dq-vfpclassps-2.c
@@ -21,7 +21,7 @@ int check_fp_class_sp (float src, int im
int PInf_res = (isinf (src) == 1);
int NInf_res = (isinf (src) == -1);
int Denorm_res = (fpclassify (src) == FP_SUBNORMAL);
- int FinNeg_res = finite (src) && (src < 0);
+ int FinNeg_res = __builtin_finite (src) && (src < 0);
int result = (((imm & 1) && qNaN_res)
|| (((imm >> 1) & 1) && Pzero_res)
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [testsuite, i386] Avoid finite in gcc.target/i386/avx512dq-vfpclasspd-2.c etc.
2015-04-08 13:27 [testsuite, i386] Avoid finite in gcc.target/i386/avx512dq-vfpclasspd-2.c etc Rainer Orth
@ 2015-04-13 18:31 ` Kirill Yukhin
2015-04-13 19:16 ` Rainer Orth
0 siblings, 1 reply; 6+ messages in thread
From: Kirill Yukhin @ 2015-04-13 18:31 UTC (permalink / raw)
To: Rainer Orth; +Cc: gcc-patches
Hello Rainer,
On 08 Apr 15:27, Rainer Orth wrote:
> Ok for mainline?
Patch is ok, thanks!
--
K
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [testsuite, i386] Avoid finite in gcc.target/i386/avx512dq-vfpclasspd-2.c etc.
2015-04-13 18:31 ` Kirill Yukhin
@ 2015-04-13 19:16 ` Rainer Orth
2015-04-13 20:37 ` Kirill Yukhin
0 siblings, 1 reply; 6+ messages in thread
From: Rainer Orth @ 2015-04-13 19:16 UTC (permalink / raw)
To: Kirill Yukhin; +Cc: gcc-patches, Jakub Jelinek, Richard Biener
Kirill Yukhin <kirill.yukhin@gmail.com> writes:
> Hello Rainer,
> On 08 Apr 15:27, Rainer Orth wrote:
>> Ok for mainline?
>
> Patch is ok, thanks!
Thanks. How about the gcc-5 branch? It would be good to avoid those
failures there, too.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [testsuite, i386] Avoid finite in gcc.target/i386/avx512dq-vfpclasspd-2.c etc.
2015-04-13 19:16 ` Rainer Orth
@ 2015-04-13 20:37 ` Kirill Yukhin
2015-04-13 21:36 ` Rainer Orth
0 siblings, 1 reply; 6+ messages in thread
From: Kirill Yukhin @ 2015-04-13 20:37 UTC (permalink / raw)
To: Rainer Orth; +Cc: gcc-patches, Jakub Jelinek, Richard Biener
On 13 Apr 21:16, Rainer Orth wrote:
> Kirill Yukhin <kirill.yukhin@gmail.com> writes:
>
> > Hello Rainer,
> > On 08 Apr 15:27, Rainer Orth wrote:
> >> Ok for mainline?
> >
> > Patch is ok, thanks!
>
> Thanks. How about the gcc-5 branch? It would be good to avoid those
> failures there, too.
Definetely! OK for gcc-5. (sorry for not mentioning that
in original mail)
--
Thanks, K
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [testsuite, i386] Avoid finite in gcc.target/i386/avx512dq-vfpclasspd-2.c etc.
2015-04-13 20:37 ` Kirill Yukhin
@ 2015-04-13 21:36 ` Rainer Orth
2015-04-14 8:12 ` Richard Biener
0 siblings, 1 reply; 6+ messages in thread
From: Rainer Orth @ 2015-04-13 21:36 UTC (permalink / raw)
To: Kirill Yukhin; +Cc: gcc-patches, Jakub Jelinek, Richard Biener
Kirill Yukhin <kirill.yukhin@gmail.com> writes:
> On 13 Apr 21:16, Rainer Orth wrote:
>> Kirill Yukhin <kirill.yukhin@gmail.com> writes:
>>
>> > Hello Rainer,
>> > On 08 Apr 15:27, Rainer Orth wrote:
>> >> Ok for mainline?
>> >
>> > Patch is ok, thanks!
>>
>> Thanks. How about the gcc-5 branch? It would be good to avoid those
>> failures there, too.
> Definetely! OK for gcc-5. (sorry for not mentioning that
> in original mail)
I believe at this point this requires RM approval. Jakub, Richard?
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [testsuite, i386] Avoid finite in gcc.target/i386/avx512dq-vfpclasspd-2.c etc.
2015-04-13 21:36 ` Rainer Orth
@ 2015-04-14 8:12 ` Richard Biener
0 siblings, 0 replies; 6+ messages in thread
From: Richard Biener @ 2015-04-14 8:12 UTC (permalink / raw)
To: Rainer Orth; +Cc: Kirill Yukhin, gcc-patches, Jakub Jelinek
On Mon, 13 Apr 2015, Rainer Orth wrote:
> Kirill Yukhin <kirill.yukhin@gmail.com> writes:
>
> > On 13 Apr 21:16, Rainer Orth wrote:
> >> Kirill Yukhin <kirill.yukhin@gmail.com> writes:
> >>
> >> > Hello Rainer,
> >> > On 08 Apr 15:27, Rainer Orth wrote:
> >> >> Ok for mainline?
> >> >
> >> > Patch is ok, thanks!
> >>
> >> Thanks. How about the gcc-5 branch? It would be good to avoid those
> >> failures there, too.
> > Definetely! OK for gcc-5. (sorry for not mentioning that
> > in original mail)
>
> I believe at this point this requires RM approval. Jakub, Richard?
Ok.
Thanks,
Richard.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-14 8:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-08 13:27 [testsuite, i386] Avoid finite in gcc.target/i386/avx512dq-vfpclasspd-2.c etc Rainer Orth
2015-04-13 18:31 ` Kirill Yukhin
2015-04-13 19:16 ` Rainer Orth
2015-04-13 20:37 ` Kirill Yukhin
2015-04-13 21:36 ` Rainer Orth
2015-04-14 8:12 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).