From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Robin Dapp <rdapp.gcc@gmail.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] testsuite/vect: Add target checks to refined patterns [PR113558]
Date: Wed, 24 Jan 2024 21:24:13 +0100 [thread overview]
Message-ID: <yddil3ixyxe.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <e16d7dba-4900-467d-bbeb-aac451e9d6b9@gmail.com> (Jeff Law's message of "Wed, 24 Jan 2024 12:46:01 -0700")
Hi Jeff,
> On 1/24/24 07:40, Robin Dapp wrote:
>> Hi,
>> on Solaris/SPARC several vector tests appeared to be regressing. They
>> were never vectorized but the checks before r14-3612-ge40edf64995769
>> would match regardless if a loop was actually vectorized or not.
>> The refined checks only match a successful vectorization attempt
>> but are run unconditionally. This patch adds target checks to them.
>> Bootstrapped (unnecessarily) and regtested on x86, aarch64 and
>> power10. Regtested on riscv and (the previous version that
>> missed vect-reduc-pattern-2a.c) on Solaris/SPARC by Rainer Orth.
>> Is this OK if Rainer's second run is successful?
>> Regards
>> Robin
>> gcc/testsuite/ChangeLog:
>> PR testsuite/113558
>> * gcc.dg/vect/no-scevccp-outer-7.c: Add target check.
>> * gcc.dg/vect/vect-outer-4c-big-array.c: Ditto.
>> * gcc.dg/vect/vect-reduc-dot-s16a.c: Ditto.
>> * gcc.dg/vect/vect-reduc-dot-s8a.c: Ditto.
>> * gcc.dg/vect/vect-reduc-dot-s8b.c: Ditto.
>> * gcc.dg/vect/vect-reduc-dot-u16b.c: Ditto.
>> * gcc.dg/vect/vect-reduc-dot-u8a.c: Ditto.
>> * gcc.dg/vect/vect-reduc-dot-u8b.c: Ditto.
>> * gcc.dg/vect/vect-reduc-pattern-1a.c: Ditto.
>> * gcc.dg/vect/vect-reduc-pattern-1b-big-array.c: Ditto.
>> * gcc.dg/vect/vect-reduc-pattern-1c-big-array.c: Ditto.
>> * gcc.dg/vect/vect-reduc-pattern-2a.c: Ditto.
>> * gcc.dg/vect/vect-reduc-pattern-2b-big-array.c: Ditto.
>> * gcc.dg/vect/wrapv-vect-reduc-dot-s8b.c: Ditto.
> Yes, OK if Rainer's run is successful. If you need to make similiar
> changes to other tests, consider them pre-approved.
sparc-sun-solaris2.11 testing just completed successfully.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
prev parent reply other threads:[~2024-01-24 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 14:40 Robin Dapp
2024-01-24 19:46 ` Jeff Law
2024-01-24 20:24 ` Rainer Orth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddil3ixyxe.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).