From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 47F043858C2F for ; Tue, 6 Sep 2022 07:42:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 47F043858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id CF4EDAC0E9; Tue, 6 Sep 2022 09:42:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EoWjxsjkWdXH; Tue, 6 Sep 2022 09:42:33 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p5085519d.dip0.t-ipconnect.de [80.133.81.157]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 2E3AFAC99A; Tue, 6 Sep 2022 09:42:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1662450153; bh=3vzWHJMJ9l0u3Roo0K25EVEzYlLCV8vhnX2vf1tqyi0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ss3/gg4ShAkgDUdl1zpRS+Q8ifiOHZvaLJ8D8M2LOejhBZCmtFFi0EMX2fPFrklTz z2/5u8ETeCrnCB/QnQBvfGym5usp+43bRd+aTglIbKlGT+xuusq563PsjrpoW8pxkV 24ayWXH/NcURSLnu/2WiMGsgP2ZzombEgte5xZYdptb1mOMlhbnFEe3OVxGa4m3A7Y miVl5XKkyJbxxxxPp5zPNygymi7t/aHQL8EsaTitCXjVXnlb7RpNVyjLlbd9A8F+RI 1z9mc3GSHnu4jGI5c9RBGDTsaGbs4p0n9y+fpZzUzOD7cKKnc3adGW/znymh2DWgWI uSgdqnkbVdNlw== From: Rainer Orth To: Iain Buclaw via Gcc-patches Cc: Richard Biener , Iain Buclaw , Joseph Myers Subject: Re: [PATCH] d: Fix #error You must define PREFERRED_DEBUGGING_TYPE if DWARF is not supported (PR105659) References: <20220816211627.209433-1-ibuclaw@gdcproject.org> <1661946124.o8swlumpp1.astroid@pulse.none> <1661972814.ht3t1le0d2.astroid@pulse.none> <1662134159.ozionptp0l.astroid@pulse.none> Date: Tue, 06 Sep 2022 09:42:32 +0200 In-Reply-To: <1662134159.ozionptp0l.astroid@pulse.none> (Iain Buclaw via Gcc-patches's message of "Fri, 02 Sep 2022 18:05:04 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3788.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Iain, > Excerpts from Richard Biener's message of September 1, 2022 8:28 am: >> On Wed, Aug 31, 2022 at 9:21 PM Iain Buclaw wrote: >>> >>> Excerpts from Joseph Myers's message of August 31, 2022 7:16 pm: >>> > On Wed, 31 Aug 2022, Iain Buclaw via Gcc-patches wrote: >>> > >>> >> Excerpts from Joseph Myers's message of August 30, 2022 11:53 pm: >>> >> > On Fri, 26 Aug 2022, Richard Biener via Gcc-patches wrote: >>> >> > >>> >> >> I was hoping Joseph would chime in here - I recollect debugging >>> >> >> this kind >>> >> >> of thing and a thread about this a while back but unfortunately I do not >>> >> >> remember the details here (IIRC some things get included where they >>> >> >> better should not be). >>> >> > >>> >> > See . >>> >> > Is there some reason it's problematic to avoid having defaults.h or >>> >> > ${cpu_type}/${cpu_type}.h included in tm_d.h, and instead have >>> >> > tm_d.h only >>> >> > include D-specific headers? >>> >> > >>> >> >>> >> In targets such as arm-elf, we still need to pull in definitions from >>> >> ${cpu_type}/${cpu_type}-d.cc into default-d.cc. >>> >> >>> >> All I can think that might suffice is having D-specific prototype >>> >> headers in all targets as ${cpu_type}/${cpu_type}-d.h. >>> > >>> > As long as those prototypes don't involve any types that depend on an >>> > inclusion of tm.h, that should be fine. >>> > >>> >>> Updated patch that does what I described. >> >> Ah yes - I think, even if a bit verbose, this is exactly how it was supposed >> to be? >> >> OK from my side. >> > > To access the TARGET macros from arm-d.cc, arm-protos.h had to be > included (after tm_p.h was removed). > > All ~200 configurations in contrib/config-list.mk now build again with > the D front-end enabled. unfortunately, this patch broke all Solaris configs (i386-pc-solaris2.11, sparc-sun-solaris2.11, sparcv9-sun-solaris2.11). libphobos configure in stage2 fails with can compile D sources configure:5402: /var/gcc/regression/master/11.4-gcc/build/./gcc/gdc -B/var/gcc/regression/master/11.4-gcc/build/./gcc/ -B/vol/gcc/i386-pc-solaris2.11/bin/ -B/vol/gcc/i386-pc-solaris2.11/lib/ -isystem /vol/gcc/i386-pc-solaris2.11/include -isystem /vol/gcc/i386-pc-solaris2.11/sys-include -fno-checking -c -fno-druntime -nostdinc -I /vol/gcc/src/hg/master/local/libphobos/libdruntime -g -O2 conftest.d >&5 core.exception.ArrayIndexError@/vol/gcc/src/hg/master/local/gcc/d/dmd/root/stringtable.d(291): index [3530971477] is out of bounds for array of length 0 gcc.deh(505): uncaught exception I don't yet see why, though. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University